From 01f1544c3bda51106ef699afd36315a21dbf110f Mon Sep 17 00:00:00 2001
From: yang-g <yangg@google.com>
Date: Tue, 28 Feb 2017 10:23:31 -0800
Subject: [PATCH] Check and act on Dump failure
---
src/cpp/server/health/default_health_check_service.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/cpp/server/health/default_health_check_service.cc b/src/cpp/server/health/default_health_check_service.cc
index 46def70e8a..bc98ce79a7 100644
--- a/src/cpp/server/health/default_health_check_service.cc
+++ b/src/cpp/server/health/default_health_check_service.cc
@@ -63,7 +63,9 @@ Status DefaultHealthCheckService::HealthCheckServiceImpl::Check(
ServerContext* context, const ByteBuffer* request, ByteBuffer* response) {
// Decode request.
std::vector<Slice> slices;
- request->Dump(&slices);
+ if (!request->Dump(&slices).ok()) {
+ return Status(StatusCode::INVALID_ARGUMENT, "");
+ }
uint8_t* request_bytes = nullptr;
bool request_bytes_owned = false;
size_t request_size = 0;
--
GitLab