From 10c040d455289b274fe2c5de00a9ffeb79798681 Mon Sep 17 00:00:00 2001
From: Vijay Pai <vpai@google.com>
Date: Thu, 22 Jun 2017 13:41:41 -0700
Subject: [PATCH] Move collection reset before unref (since unref could destroy
obj)
---
include/grpc++/impl/codegen/call.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/grpc++/impl/codegen/call.h b/include/grpc++/impl/codegen/call.h
index dba53bc427..342ea46203 100644
--- a/include/grpc++/impl/codegen/call.h
+++ b/include/grpc++/impl/codegen/call.h
@@ -610,10 +610,12 @@ class CallOpSet : public CallOpSetInterface,
this->Op5::FinishOp(status);
this->Op6::FinishOp(status);
*tag = return_tag_;
- g_core_codegen_interface->grpc_call_unref(call_);
+
// TODO(vjpai): Remove the reference to collection_ once the idea of
// bypassing the code generator is forbidden. It is already deprecated
collection_.reset();
+
+ g_core_codegen_interface->grpc_call_unref(call_);
return true;
}
--
GitLab