From 158a4a42b2dfd1712b3ca81daf68162df04460c6 Mon Sep 17 00:00:00 2001
From: "Mark D. Roth" <roth@google.com>
Date: Fri, 2 Dec 2016 10:53:26 -0800
Subject: [PATCH] Add comment about testing with reviewable.

---
 tools/run_tests/jobset.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/run_tests/jobset.py b/tools/run_tests/jobset.py
index 8c3b6ddda8..2acc7971f6 100755
--- a/tools/run_tests/jobset.py
+++ b/tools/run_tests/jobset.py
@@ -50,6 +50,10 @@ _DEFAULT_MAX_JOBS = 16 * multiprocessing.cpu_count()
 _MAX_RESULT_SIZE = 8192
 
 
+# NOTE: If you change this, please make sure to test reviewing the
+# github PR with http://reviewable.io, which is known to add UTF-8
+# characters to the PR description, which leak into the environment here
+# and cause failures.
 def strip_non_ascii_chars(s):
   return ''.join(c for c in s if ord(c) < 128)
 
-- 
GitLab