From 1a8c52e47910bc32ed963fd8f56efb00c91883c7 Mon Sep 17 00:00:00 2001
From: Craig Tiller <ctiller@google.com>
Date: Wed, 28 Sep 2016 17:28:04 -0700
Subject: [PATCH] Collect stats on # failed requests
---
src/proto/grpc/testing/control.proto | 1 +
test/cpp/qps/driver.cc | 2 ++
test/cpp/qps/qps_json_driver.cc | 5 +++++
3 files changed, 8 insertions(+)
diff --git a/src/proto/grpc/testing/control.proto b/src/proto/grpc/testing/control.proto
index 8cffca5f2c..83c41508a7 100644
--- a/src/proto/grpc/testing/control.proto
+++ b/src/proto/grpc/testing/control.proto
@@ -219,6 +219,7 @@ message ScenarioResultSummary
double latency_99 = 10;
double latency_999 = 11;
+ // Number of requests that succeeded/failed
int64 successful_requests = 12;
int64 failed_requests = 13;
}
diff --git a/test/cpp/qps/driver.cc b/test/cpp/qps/driver.cc
index fea94a3cb2..29e53f383d 100644
--- a/test/cpp/qps/driver.cc
+++ b/test/cpp/qps/driver.cc
@@ -169,6 +169,8 @@ static void postprocess_scenario_result(ScenarioResult* result) {
failures += rrc.count();
}
}
+ result->mutable_summary()->set_successful_requests(successes);
+ result->mutable_summary()->set_failed_requests(successes);
}
}
diff --git a/test/cpp/qps/qps_json_driver.cc b/test/cpp/qps/qps_json_driver.cc
index 1524ebbc38..4a9745c66e 100644
--- a/test/cpp/qps/qps_json_driver.cc
+++ b/test/cpp/qps/qps_json_driver.cc
@@ -110,6 +110,11 @@ static bool QpsDriver() {
GetReporter()->ReportLatency(*result);
GetReporter()->ReportTimes(*result);
+ if (result->mutable_summary()->failed_requests()) {
+ std::cerr << "# failed requests: "
+ << result->mutable_summary()->failed_requests() << "\n";
+ }
+
for (int i = 0; success && i < result->client_success_size(); i++) {
success = result->client_success(i);
}
--
GitLab