From 3f818ccf0009ebc5d4dd8718c51c28b76cdd8d31 Mon Sep 17 00:00:00 2001
From: Connor Peet <connor@peet.io>
Date: Wed, 2 Aug 2017 09:23:41 -0700
Subject: [PATCH] Node: document that root_certs in createSsl is optional
It appears that omitting it causes grpc to use the hosts' default cert data.
This was brought up (as I had implemented this method incorrectly) in:
https://github.com/mixer/etcd3/issues/28#issuecomment-319510441
---
src/node/src/credentials.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node/src/credentials.js b/src/node/src/credentials.js
index dfc1acaf40..d68d888e6a 100644
--- a/src/node/src/credentials.js
+++ b/src/node/src/credentials.js
@@ -82,7 +82,7 @@ var _ = require('lodash');
* @memberof grpc.credentials
* @alias grpc.credentials.createSsl
* @kind function
- * @param {Buffer} root_certs The root certificate data
+ * @param {Buffer=} root_certs The root certificate data
* @param {Buffer=} private_key The client certificate private key, if
* applicable
* @param {Buffer=} cert_chain The client certificate cert chain, if applicable
--
GitLab