From 504adae3722d6ea9f952f8990be16e5490fa1a6b Mon Sep 17 00:00:00 2001
From: Matt Kwong <mattkwong@google.com>
Date: Fri, 24 Mar 2017 17:01:27 -0700
Subject: [PATCH] Add a TODO to enable microbenmarking for performance testing
---
tools/jenkins/run_performance.sh | 4 ++--
tools/run_tests/run_microbenchmark.py | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/jenkins/run_performance.sh b/tools/jenkins/run_performance.sh
index c3be3082d4..2b05a8d04d 100755
--- a/tools/jenkins/run_performance.sh
+++ b/tools/jenkins/run_performance.sh
@@ -37,6 +37,6 @@ BENCHMARKS_TO_RUN="bm_closure bm_cq bm_call_create bm_error bm_chttp2_hpack bm_c
# Enter the gRPC repo root
cd $(dirname $0)/../..
-# tools/run_tests/run_performance_tests.py -l c++ node ruby csharp python --netperf --category smoketest
+tools/run_tests/run_performance_tests.py -l c++ node ruby csharp python --netperf --category smoketest
# todo(mattkwong): Change performance test to use microbenchmarking
-tools/run_tests/run_microbenchmark.py -c summary --diff_perf origin/$ghprbTargetBranch -b $BENCHMARKS_TO_RUN
+# tools/run_tests/run_microbenchmark.py -c summary --diff_perf origin/$ghprbTargetBranch -b $BENCHMARKS_TO_RUN
diff --git a/tools/run_tests/run_microbenchmark.py b/tools/run_tests/run_microbenchmark.py
index 8b9170edf4..19cf16ed49 100755
--- a/tools/run_tests/run_microbenchmark.py
+++ b/tools/run_tests/run_microbenchmark.py
@@ -245,8 +245,7 @@ try:
run_summary(bm_name, 'opt', bm_name)
run_summary(bm_name, 'counters', bm_name)
where_am_i = subprocess.check_output(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip()
- # todo(mattkwong): uncomment this before merging
- # subprocess.check_call(['git', 'checkout', args.diff_perf])
+ subprocess.check_call(['git', 'checkout', args.diff_perf])
comparables = []
subprocess.check_call(['make', 'clean'])
try:
--
GitLab