From 703c042ec00f1bef0b7e1e62276fe8b7fb36391a Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Tue, 31 May 2016 15:46:10 -0700
Subject: [PATCH] serverside shutdown hook test
---
.../Grpc.Core.Tests/Grpc.Core.Tests.csproj | 1 +
.../Grpc.Core.Tests/ShutdownHookServerTest.cs | 75 +++++++++++++++++++
.../Grpc.Core.Tests/ShutdownHookTest.cs | 13 ++--
.../Grpc.Core/Internal/GrpcThreadPool.cs | 2 +-
src/csharp/tests.json | 1 +
5 files changed, 85 insertions(+), 7 deletions(-)
create mode 100644 src/csharp/Grpc.Core.Tests/ShutdownHookServerTest.cs
diff --git a/src/csharp/Grpc.Core.Tests/Grpc.Core.Tests.csproj b/src/csharp/Grpc.Core.Tests/Grpc.Core.Tests.csproj
index 905e1e7f7e..0a1e8a6938 100644
--- a/src/csharp/Grpc.Core.Tests/Grpc.Core.Tests.csproj
+++ b/src/csharp/Grpc.Core.Tests/Grpc.Core.Tests.csproj
@@ -87,6 +87,7 @@
<Compile Include="Internal\FakeNativeCall.cs" />
<Compile Include="Internal\AsyncCallServerTest.cs" />
<Compile Include="ShutdownHookTest.cs" />
+ <Compile Include="ShutdownHookServerTest.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<ItemGroup>
diff --git a/src/csharp/Grpc.Core.Tests/ShutdownHookServerTest.cs b/src/csharp/Grpc.Core.Tests/ShutdownHookServerTest.cs
new file mode 100644
index 0000000000..7990a7d15f
--- /dev/null
+++ b/src/csharp/Grpc.Core.Tests/ShutdownHookServerTest.cs
@@ -0,0 +1,75 @@
+#region Copyright notice and license
+
+// Copyright 2015, Google Inc.
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+#endregion
+
+using System;
+using System.Diagnostics;
+using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
+using Grpc.Core;
+using Grpc.Core.Internal;
+using Grpc.Core.Utils;
+using NUnit.Framework;
+
+namespace Grpc.Core.Tests
+{
+ public class ShutdownHookServerTest
+ {
+ const string Host = "127.0.0.1";
+
+ /// <summary>
+ /// Make sure that a non-shutdown server can be cleaned up using
+ /// a <c>AppDomain.ProcessExit</c> hook.
+ /// </summary>
+ [Test]
+ public void AppDomainProcessExitHook()
+ {
+ var helper = new MockServiceHelper(Host);
+ var server = helper.GetServer();
+ server.Start();
+ AppDomain.CurrentDomain.ProcessExit += (object sender, EventArgs e) =>
+ {
+ // TODO: expose API for killing all servers
+ // TODO: expose API for closing all channels
+ server.KillAsync();
+ GrpcEnvironment.ReleaseAsync();
+ };
+ }
+
+ // TODO: test what happens if there's a pending completion in the cq (destroy on non-empty cq)
+
+ // TODO: test what happens if there's an appdomain unload
+
+ // TODO: tests involving a server...
+ }
+}
diff --git a/src/csharp/Grpc.Core.Tests/ShutdownHookTest.cs b/src/csharp/Grpc.Core.Tests/ShutdownHookTest.cs
index 0464929077..301ae091c6 100644
--- a/src/csharp/Grpc.Core.Tests/ShutdownHookTest.cs
+++ b/src/csharp/Grpc.Core.Tests/ShutdownHookTest.cs
@@ -55,16 +55,17 @@ namespace Grpc.Core.Tests
public void AppDomainProcessExitHook()
{
var channel = new Channel(Host, 1000, ChannelCredentials.Insecure);
- AppDomain.CurrentDomain.DomainUnload += (object sender, EventArgs e) =>
- {
- Console.WriteLine("DomainUnload");
- channel.ShutdownAsync();
- };
AppDomain.CurrentDomain.ProcessExit += (object sender, EventArgs e) =>
{
- Console.WriteLine("ProcessExit");
+ // TODO: expose API to shutdown all channels.
channel.ShutdownAsync();
};
}
+
+ // TODO: test what happens if there's a pending completion in the cq (destroy on non-empty cq)
+
+ // TODO: test what happens if there's an appdomain unload
+
+ // TODO: tests involving a server...
}
}
diff --git a/src/csharp/Grpc.Core/Internal/GrpcThreadPool.cs b/src/csharp/Grpc.Core/Internal/GrpcThreadPool.cs
index f50f2a6e39..8643abf536 100644
--- a/src/csharp/Grpc.Core/Internal/GrpcThreadPool.cs
+++ b/src/csharp/Grpc.Core/Internal/GrpcThreadPool.cs
@@ -128,7 +128,7 @@ namespace Grpc.Core.Internal
var cq = completionQueues.ElementAt(cqIndex);
var thread = new Thread(new ThreadStart(() => RunHandlerLoop(cq)));
- thread.IsBackground = false;
+ thread.IsBackground = true;
thread.Name = string.Format("grpc {0} (cq {1})", threadIndex, cqIndex);
thread.Start();
diff --git a/src/csharp/tests.json b/src/csharp/tests.json
index 9d37c6fc9e..d80e95a3a4 100644
--- a/src/csharp/tests.json
+++ b/src/csharp/tests.json
@@ -25,6 +25,7 @@
"Grpc.Core.Tests.ResponseHeadersTest",
"Grpc.Core.Tests.SanityTest",
"Grpc.Core.Tests.ServerTest",
+ "Grpc.Core.Tests.ShutdownHookServerTest",
"Grpc.Core.Tests.ShutdownHookTest",
"Grpc.Core.Tests.ShutdownTest",
"Grpc.Core.Tests.TimeoutsTest",
--
GitLab