From 852b7d9fdef9472ccef14c8ba83fe62ceb2246b2 Mon Sep 17 00:00:00 2001
From: Craig Tiller <ctiller@google.com>
Date: Thu, 30 Mar 2017 08:15:16 -0700
Subject: [PATCH] Add debug: somethings going wrong
---
tools/profiling/microbenchmarks/bm_diff.py | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/profiling/microbenchmarks/bm_diff.py b/tools/profiling/microbenchmarks/bm_diff.py
index 2c4e572d12..f1d29ba3c6 100755
--- a/tools/profiling/microbenchmarks/bm_diff.py
+++ b/tools/profiling/microbenchmarks/bm_diff.py
@@ -174,7 +174,10 @@ class Benchmark:
old_mdn = median(old)
delta = new_mdn - old_mdn
ratio = changed_ratio(new_mdn, old_mdn)
- if p < args.p_threshold and abs(delta) > 0.1 and abs(ratio) > 0.1:
+ print 'new=%r old=%r new_mdn=%f old_mdn=%f delta=%f ratio=%f p=%f' % (
+ new, old, new_mdn, old_mdn, delta, ratio, p
+ )
+ if p < args.p_threshold and abs(delta) > 0.1 and abs(ratio) > 0.03:
self.final[f] = delta
return self.final.keys()
@@ -207,7 +210,8 @@ for bm in comparables:
benchmarks[name].add_sample(row, False)
really_interesting = set()
-for bm in benchmarks.values():
+for name, bm in benchmarks.items():
+ print name
really_interesting.update(bm.process())
fields = [f for f in _INTERESTING if f in really_interesting]
--
GitLab