From b423f579e44f30f6c4ac3498ad1fc738fa8c8895 Mon Sep 17 00:00:00 2001
From: ncteisen <ncteisen@gmail.com>
Date: Wed, 14 Jun 2017 11:45:12 -0700
Subject: [PATCH] Disambiguate trickle and normal bms
---
tools/jenkins/run_performance.sh | 2 +-
tools/profiling/microbenchmarks/bm_diff/bm_main.py | 9 +++++++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/jenkins/run_performance.sh b/tools/jenkins/run_performance.sh
index d3f23ddd79..da905d0249 100755
--- a/tools/jenkins/run_performance.sh
+++ b/tools/jenkins/run_performance.sh
@@ -20,4 +20,4 @@ set -ex
cd $(dirname $0)/../..
tools/run_tests/start_port_server.py
-tools/profiling/microbenchmarks/bm_diff/bm_main.py -d origin/$ghprbTargetBranch -b bm_fullstack_trickle -l 4 -t cli_transport_stalls cli_stream_stalls svr_transport_stalls svr_stream_stalls --no-counters
+tools/profiling/microbenchmarks/bm_diff/bm_main.py -d origin/$ghprbTargetBranch -b bm_fullstack_trickle -l 4 -t cli_transport_stalls cli_stream_stalls svr_transport_stalls svr_stream_stalls --no-counters --pr_comment_name trickle
diff --git a/tools/profiling/microbenchmarks/bm_diff/bm_main.py b/tools/profiling/microbenchmarks/bm_diff/bm_main.py
index 51208cb965..8b4e0cb69a 100755
--- a/tools/profiling/microbenchmarks/bm_diff/bm_main.py
+++ b/tools/profiling/microbenchmarks/bm_diff/bm_main.py
@@ -80,6 +80,11 @@ def _args():
type=int,
default=multiprocessing.cpu_count(),
help='Number of CPUs to use')
+ argp.add_argument(
+ '--pr_comment_name',
+ type=str,
+ default="microbenchmarks",
+ help='Name that Jenkins will use to commen on the PR')
argp.add_argument('--counters', dest='counters', action='store_true')
argp.add_argument('--no-counters', dest='counters', action='store_false')
argp.set_defaults(counters=True)
@@ -126,9 +131,9 @@ def main(args):
diff, note = bm_diff.diff(args.benchmarks, args.loops, args.track, old,
'new', args.counters)
if diff:
- text = 'Performance differences noted:\n' + diff
+ text = '[%s] Performance differences noted:\n%s' % (args.pr_comment_name, diff)
else:
- text = 'No significant performance differences'
+ text = '[%s] No significant performance differences' % args.pr_comment_name
if note:
text = note + '\n\n' + text
print('%s' % text)
--
GitLab