diff --git a/binding.gyp b/binding.gyp index 52e0ea6c394e89478927ed37465d8568f2acc4ba..32e44dd61a098a010f7b3a06b510e814d61b6bd7 100644 --- a/binding.gyp +++ b/binding.gyp @@ -346,11 +346,12 @@ "src/node/ext/node_grpc.cc", "src/node/ext/server.cc", "src/node/ext/server_credentials.cc", - "src/node/ext/timeval.cc" + "src/node/ext/timeval.cc", ], "dependencies": [ - "grpc" + "grpc", + "gpr", ] - } + }, ] } diff --git a/build.yaml b/build.yaml index 873606f98064fcb9d8fbbb5cf5c588b7f5e751bb..38dce3ce0d77586bfe317ec09ad3e6d285ee42c2 100644 --- a/build.yaml +++ b/build.yaml @@ -2232,3 +2232,19 @@ vspackages: props: false redist: false version: 1.7.0.1 +node_modules: +- deps: + - grpc + - gpr + name: grpc_node + src: + - src/node/ext/byte_buffer.cc + - src/node/ext/call.cc + - src/node/ext/call_credentials.cc + - src/node/ext/channel.cc + - src/node/ext/channel_credentials.cc + - src/node/ext/completion_queue_async_worker.cc + - src/node/ext/node_grpc.cc + - src/node/ext/server.cc + - src/node/ext/server_credentials.cc + - src/node/ext/timeval.cc diff --git a/templates/binding.gyp.template b/templates/binding.gyp.template index 52070cf6e9e6c0ac450c95321df813eca0e125f4..be80750eb7f67877fe790a08da034e608bdf5964 100644 --- a/templates/binding.gyp.template +++ b/templates/binding.gyp.template @@ -89,8 +89,9 @@ ] }, 'targets': [ + % for module in node_modules: % for lib in libs: - % if lib.name == 'gpr' or lib.name == 'grpc': + % if lib.name in module.transitive_deps: { 'target_name': '${lib.name}', 'product_prefix': 'lib', @@ -142,22 +143,18 @@ } }] ], - "target_name": "grpc_node", + "target_name": "${module.name}", "sources": [ - "src/node/ext/byte_buffer.cc", - "src/node/ext/call.cc", - "src/node/ext/call_credentials.cc", - "src/node/ext/channel.cc", - "src/node/ext/channel_credentials.cc", - "src/node/ext/completion_queue_async_worker.cc", - "src/node/ext/node_grpc.cc", - "src/node/ext/server.cc", - "src/node/ext/server_credentials.cc", - "src/node/ext/timeval.cc" + % for source in module.src: + "${source}", + % endfor ], "dependencies": [ - "grpc" + % for dep in getattr(module, 'deps', []): + "${dep}", + % endfor ] - } + }, + % endfor ] } diff --git a/tools/buildgen/plugins/transitive_dependencies.py b/tools/buildgen/plugins/transitive_dependencies.py new file mode 100644 index 0000000000000000000000000000000000000000..c2d3da3a3b264dd95256fb7c24e2a9a554651d06 --- /dev/null +++ b/tools/buildgen/plugins/transitive_dependencies.py @@ -0,0 +1,63 @@ +# Copyright 2015, Google Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +"""Buildgen transitive dependencies + +This takes the list of libs, node_modules, and targets from our +yaml dictionary, and adds to each the transitive closure +of the list of dependencies. + +""" + +def get_lib(libs, name): + return next(lib for lib in libs if lib['name']==name) + +def transitive_deps(lib, libs): + if 'deps' in lib: + # Recursively call transitive_deps on each dependency, and take the union + return set.union(set(lib['deps']), + *[set(transitive_deps(get_lib(libs, dep), libs)) + for dep in lib['deps']]) + else: + return set() + +def mako_plugin(dictionary): + """The exported plugin code for transitive_dependencies. + + Each item in libs, node_modules, and targets can have a deps list. + We add a transitive_deps property to each with the transitive closure + of those dependency lists. + """ + libs = dictionary.get('libs') + node_modules = dictionary.get('node_modules') + targets = dictionary.get('targets') + + for target_list in (libs, node_modules, targets): + for target in target_list: + target['transitive_deps'] = transitive_deps(target, libs)