From c0034dd10b93dccef33d92f4b1990a6ac30b06aa Mon Sep 17 00:00:00 2001
From: Stanley Cheung <stanleycheung@google.com>
Date: Mon, 27 Jul 2015 12:26:15 -0700
Subject: [PATCH] review feedback: unit test of uri value too strict
---
src/php/tests/interop/interop_client.php | 2 +-
src/php/tests/unit_tests/CallTest.php | 2 +-
src/php/tests/unit_tests/EndToEndTest.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/php/tests/interop/interop_client.php b/src/php/tests/interop/interop_client.php
index 4bcf7df7f7..44e6242c29 100755
--- a/src/php/tests/interop/interop_client.php
+++ b/src/php/tests/interop/interop_client.php
@@ -333,7 +333,7 @@ if (in_array($args['test_case'], array(
}
$internal_stub = new Grpc\BaseStub($server_address, $opts);
-hardAssert($internal_stub->getTarget() == $server_address,
+hardAssert(is_string($internal_stub->getTarget()),
'Unexpected target URI value');
$stub = new grpc\testing\TestServiceClient($internal_stub);
diff --git a/src/php/tests/unit_tests/CallTest.php b/src/php/tests/unit_tests/CallTest.php
index 3d50da3251..caff15ee11 100755
--- a/src/php/tests/unit_tests/CallTest.php
+++ b/src/php/tests/unit_tests/CallTest.php
@@ -81,6 +81,6 @@ class CallTest extends PHPUnit_Framework_TestCase{
}
public function testGetPeer() {
- $this->assertTrue($this->call->getPeer() == 'localhost:' . self::$port);
+ $this->assertTrue(is_string($this->call->getPeer()));
}
}
diff --git a/src/php/tests/unit_tests/EndToEndTest.php b/src/php/tests/unit_tests/EndToEndTest.php
index 9a1ab81acc..27e27cdfdf 100755
--- a/src/php/tests/unit_tests/EndToEndTest.php
+++ b/src/php/tests/unit_tests/EndToEndTest.php
@@ -151,6 +151,6 @@ class EndToEndTest extends PHPUnit_Framework_TestCase{
}
public function testGetTarget() {
- $this->assertTrue($this->channel->getTarget() == 'localhost:' . $this->port);
+ $this->assertTrue(is_string($this->channel->getTarget()));
}
}
--
GitLab