Skip to content
Snippets Groups Projects
Commit eb24a7bd authored by Craig Tiller's avatar Craig Tiller
Browse files

Use new diff script

parent 3651eece
No related branches found
No related tags found
No related merge requests found
...@@ -228,8 +228,10 @@ for bm_name in args.benchmarks: ...@@ -228,8 +228,10 @@ for bm_name in args.benchmarks:
for collect in args.collect: for collect in args.collect:
collectors[collect](bm_name, args) collectors[collect](bm_name, args)
if args.diff_perf: if args.diff_perf:
if 'summary' not in args.collect:
for bm_name in args.benchmarks: for bm_name in args.benchmarks:
run_summary(bm_name, 'opt', '%s.new' % bm_name) run_summary(bm_name, 'opt', bm_name)
run_summary(bm_name, 'counters', bm_name)
where_am_i = subprocess.check_output(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip() where_am_i = subprocess.check_output(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip()
subprocess.check_call(['git', 'checkout', args.diff_perf]) subprocess.check_call(['git', 'checkout', args.diff_perf])
comparables = [] comparables = []
...@@ -238,15 +240,21 @@ if args.diff_perf: ...@@ -238,15 +240,21 @@ if args.diff_perf:
for bm_name in args.benchmarks: for bm_name in args.benchmarks:
try: try:
run_summary(bm_name, 'opt', '%s.old' % bm_name) run_summary(bm_name, 'opt', '%s.old' % bm_name)
run_summary(bm_name, 'counters', '%s.old' % bm_name)
comparables.append(bm_name) comparables.append(bm_name)
except subprocess.CalledProcessError, e: except subprocess.CalledProcessError, e:
pass pass
finally: finally:
subprocess.check_call(['git', 'checkout', where_am_i]) subprocess.check_call(['git', 'checkout', where_am_i])
for bm_name in comparables: for bm_name in comparables:
subprocess.check_call(['third_party/benchmark/tools/compare_bench.py', diff = subprocess.check_output(['tools/profiling/microbenchmarks/bm_diff.py',
'%s.new.opt.json' % bm_name, '%s.opt.json' % bm_name,
'%s.old.opt.json' % bm_name]) '%s.counters.json' % bm_name,
'%s.old.opt.json' % bm_name,
'%s.old.counters.json' % bm_name]).strip()
if diff:
heading('Performance diff: %s' % bm_name)
text(diff)
index_html += "</body>\n</html>\n" index_html += "</body>\n</html>\n"
with open('reports/index.html', 'w') as f: with open('reports/index.html', 'w') as f:
... ...
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment