From f7c8e8be6260047301dd5c73f5fcbd849d5726b0 Mon Sep 17 00:00:00 2001
From: Yash Tibrewal <yashkt@google.com>
Date: Wed, 24 Apr 2019 16:51:59 -0700
Subject: [PATCH] clang tidy
---
src/core/ext/filters/client_channel/lb_policy/xds/xds.cc | 4 ++--
test/core/client_channel/service_config_test.cc | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/core/ext/filters/client_channel/lb_policy/xds/xds.cc b/src/core/ext/filters/client_channel/lb_policy/xds/xds.cc
index 26d34e1b3f..9e9cee3d3a 100644
--- a/src/core/ext/filters/client_channel/lb_policy/xds/xds.cc
+++ b/src/core/ext/filters/client_channel/lb_policy/xds/xds.cc
@@ -1750,7 +1750,7 @@ void XdsLb::LocalityMap::PruneLocalities(const LocalityList& locality_list) {
void XdsLb::LocalityMap::UpdateLocked(
const LocalityList& locality_serverlist,
- RefCountedPtr<ParsedLoadBalancingConfig> child_policy_config,
+ const RefCountedPtr<ParsedLoadBalancingConfig>& child_policy_config,
const grpc_channel_args* args, XdsLb* parent) {
if (parent->shutting_down_) return;
for (size_t i = 0; i < locality_serverlist.size(); i++) {
@@ -1845,7 +1845,7 @@ XdsLb::LocalityMap::LocalityEntry::CreateChildPolicyLocked(
void XdsLb::LocalityMap::LocalityEntry::UpdateLocked(
xds_grpclb_serverlist* serverlist,
- RefCountedPtr<ParsedLoadBalancingConfig> child_policy_config,
+ const RefCountedPtr<ParsedLoadBalancingConfig>& child_policy_config,
const grpc_channel_args* args_in) {
if (parent_->shutting_down_) return;
// Construct update args.
diff --git a/test/core/client_channel/service_config_test.cc b/test/core/client_channel/service_config_test.cc
index fd5304c17d..7a41283012 100644
--- a/test/core/client_channel/service_config_test.cc
+++ b/test/core/client_channel/service_config_test.cc
@@ -137,7 +137,7 @@ class ErrorParser : public ServiceConfig::Parser {
static const char* GlobalError() { return "ErrorParser : globalError"; }
};
-void VerifyRegexMatch(grpc_error* error, std::regex e) {
+void VerifyRegexMatch(grpc_error* error, const std::regex& e) {
std::smatch match;
std::string s(grpc_error_string(error));
EXPECT_TRUE(std::regex_search(s, match, e));
--
GitLab