Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
000fa388
Commit
000fa388
authored
9 years ago
by
Jorge Canizales
Browse files
Options
Downloads
Patches
Plain Diff
Clarify comments in GRPCHost.m
parent
e8543b07
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/objective-c/GRPCClient/private/GRPCHost.m
+5
-4
5 additions, 4 deletions
src/objective-c/GRPCClient/private/GRPCHost.m
with
5 additions
and
4 deletions
src/objective-c/GRPCClient/private/GRPCHost.m
+
5
−
4
View file @
000fa388
...
@@ -38,7 +38,7 @@
...
@@ -38,7 +38,7 @@
#import "GRPCUnsecuredChannel.h"
#import "GRPCUnsecuredChannel.h"
@interface
GRPCHost
()
@interface
GRPCHost
()
// TODO(mlumish): Investigate whether
a
caching channels with strong links is a good idea.
// TODO(mlumish): Investigate whether caching channels with strong links is a good idea.
@property
(
nonatomic
,
strong
)
GRPCChannel
*
channel
;
@property
(
nonatomic
,
strong
)
GRPCChannel
*
channel
;
@end
@end
...
@@ -80,8 +80,8 @@
...
@@ -80,8 +80,8 @@
});
});
if
(
hostCache
[
address
])
{
if
(
hostCache
[
address
])
{
// We could verify here that the cached host uses the same protocol that we're expecting. But
// We could verify here that the cached host uses the same protocol that we're expecting. But
//
picking HTTP
by adding
the scheme
to the address is going away (to make the use
of insecure
//
creating non-SSL channels
by adding
"http://"
to the address is going away (to make the use
// channels less subtle), so it's not worth it now.
//
of insecure
channels less subtle), so it's not worth it now.
return
hostCache
[
address
];
return
hostCache
[
address
];
}
}
...
@@ -105,7 +105,8 @@
...
@@ -105,7 +105,8 @@
}
}
-
(
GRPCChannel
*
)
channel
{
-
(
GRPCChannel
*
)
channel
{
// Create it lazily.
// Create it lazily, because we don't want to open a connection just because someone is
// configuring a host.
if
(
!
_channel
)
{
if
(
!
_channel
)
{
if
(
_secure
)
{
if
(
_secure
)
{
_channel
=
[[
GRPCSecureChannel
alloc
]
initWithHost
:
_address
_channel
=
[[
GRPCSecureChannel
alloc
]
initWithHost
:
_address
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment