code style fixes based on StyleCop warnings

src/csharp/Grpc.Core.Tests/ClientServerTest.cs

@@ -122,10 +122,13 @@ namespace Grpc.Core.Tests
             {
                 var call = new Call<string, string>(unaryEchoStringMethod, channel);
 
-                try {
+                try
+                {
                     Calls.BlockingUnaryCall(call, "ABC", default(CancellationToken));
                     Assert.Fail();
-                } catch(RpcException e) {
+                }
+                catch (RpcException e)
+                {
                     Assert.AreEqual(StatusCode.Unimplemented, e.Status.StatusCode);
                 }
             }
@@ -140,4 +143,3 @@ namespace Grpc.Core.Tests
         }
     }
 }
-

src/csharp/Grpc.Core.Tests/GrpcEnvironmentTest.cs

@@ -68,7 +68,7 @@ namespace Grpc.Core.Tests
             var tp2 = GrpcEnvironment.ThreadPool;
             GrpcEnvironment.Shutdown();
 
-            Assert.IsFalse(Object.ReferenceEquals(tp1, tp2));
+            Assert.IsFalse(object.ReferenceEquals(tp1, tp2));
         }
     }
 }

src/csharp/Grpc.Core.Tests/PInvokeTest.cs

@@ -33,13 +33,13 @@
 
 using System;
 using System.Diagnostics;
+using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Grpc.Core;
 using Grpc.Core.Internal;
 using Grpc.Core.Utils;
 using NUnit.Framework;
-using System.Runtime.InteropServices;
 
 namespace Grpc.Core.Tests
 {
@@ -73,14 +73,13 @@ namespace Grpc.Core.Tests
         {
             BenchmarkUtil.RunBenchmark(
                 100000, 1000000,
-                () => {
+                () =>
+                {
                     CompletionQueueSafeHandle cq = CompletionQueueSafeHandle.Create();
                     cq.Dispose();
-                }
-            );
+                });
         }
 
-
         /// <summary>
         /// Approximate results:
         /// (~80ns Mono Linux)
@@ -94,10 +93,10 @@ namespace Grpc.Core.Tests
             counter = 0;
             BenchmarkUtil.RunBenchmark(
                 1000000, 10000000,
-                () => {
+                () =>
+                {
                     grpcsharp_test_callback(handler);
-                }
-            );
+                });
             Assert.AreNotEqual(0, counter);
         }
 
@@ -113,10 +112,10 @@ namespace Grpc.Core.Tests
             counter = 0;
             BenchmarkUtil.RunBenchmark(
                 10000, 10000,
-                () => {
+                () =>
+                {
                     grpcsharp_test_callback(new CompletionCallbackDelegate(Handler));
-            }
-            );
+                });
             Assert.AreNotEqual(0, counter);
         }
 
@@ -129,15 +128,15 @@ namespace Grpc.Core.Tests
         {
             BenchmarkUtil.RunBenchmark(
                 1000000, 100000000,
-                () => {
+                () =>
+                {
                     grpcsharp_test_nop(IntPtr.Zero);
-                }
-            );
+                });
         }
 
-        private void Handler(GRPCOpError op, IntPtr ptr) {
+        private void Handler(GRPCOpError op, IntPtr ptr)
+        {
             counter++;
         }
     }
 }
-

src/csharp/Grpc.Core.Tests/Properties/AssemblyInfo.cs

 using System.Reflection;
 using System.Runtime.CompilerServices;
 
-// Information about this assembly is defined by the following attributes.
-// Change them to the values specific to your project.
 [assembly: AssemblyTitle("Grpc.Core.Tests")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
@@ -11,12 +9,4 @@ using System.Runtime.CompilerServices;
 [assembly: AssemblyCopyright("Google Inc.  All rights reserved.")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
-// The assembly version has the format "{Major}.{Minor}.{Build}.{Revision}".
-// The form "{Major}.{Minor}.*" will automatically update the build and revision,
-// and "{Major}.{Minor}.{Build}.*" will update just the revision.
 [assembly: AssemblyVersion("0.1.*")]
-// The following attributes are used to specify the signing key for the assembly,
-// if desired. See the Mono documentation for more information about signing.
-//[assembly: AssemblyDelaySign(false)]
-//[assembly: AssemblyKeyFile("")]
-

src/csharp/Grpc.Core.Tests/ServerTest.cs

@@ -53,6 +53,5 @@ namespace Grpc.Core.Tests
 
             GrpcEnvironment.Shutdown();
         }
-
     }
 }

src/csharp/Grpc.Core.Tests/TimespecTest.cs

@@ -86,4 +86,3 @@ namespace Grpc.Core.Internal.Tests
         }
     }
 }
-

src/csharp/Grpc.Core/Call.cs

@@ -47,7 +47,8 @@ namespace Grpc.Core
                     Func<TRequest, byte[]> requestSerializer,
                     Func<byte[], TResponse> responseDeserializer,
                     TimeSpan timeout,
-                    Channel channel) {
+                    Channel channel)
+        {
             this.methodName = methodName;
             this.requestSerializer = requestSerializer;
             this.responseDeserializer = responseDeserializer;
@@ -95,4 +96,3 @@ namespace Grpc.Core
         }
     }
 }
-

src/csharp/Grpc.Core/Calls.cs

@@ -89,9 +89,9 @@ namespace Grpc.Core
             return new ClientStreamingInputObserver<TRequest, TResponse>(asyncCall);
         }
 
-        private static CompletionQueueSafeHandle GetCompletionQueue() {
+        private static CompletionQueueSafeHandle GetCompletionQueue()
+        {
             return GrpcEnvironment.ThreadPool.CompletionQueue;
         }
     }
 }
-

src/csharp/Grpc.Core/Channel.cs

@@ -39,7 +39,7 @@ namespace Grpc.Core
     public class Channel : IDisposable
     {
         readonly ChannelSafeHandle handle;
-        readonly String target;
+        readonly string target;
 
         /// <summary>
         /// Creates a channel.

src/csharp/Grpc.Core/ClientStreamingAsyncResult.cs

@@ -67,4 +67,3 @@ namespace Grpc.Core
         }
     }
 }
-

src/csharp/Grpc.Core/Credentials.cs

@@ -74,4 +74,3 @@ namespace Grpc.Core
         }
     }
 }
-

src/csharp/Grpc.Core/GrpcEnvironment.cs

@@ -63,7 +63,8 @@ namespace Grpc.Core
         /// lifetime (and call Shutdown once you're done), for the sake of easier testing it's
         /// allowed to initialize the environment again after it has been successfully shutdown.
         /// </summary>
-        public static void Initialize() {
+        public static void Initialize()
+        {
             lock (staticLock)
             {
                 if (instance == null)
@@ -133,4 +134,3 @@ namespace Grpc.Core
         }
     }
 }
-

src/csharp/Grpc.Core/Internal/AsyncCall.cs

@@ -54,7 +54,7 @@ namespace Grpc.Core.Internal
         TaskCompletionSource<TResponse> unaryResponseTcs;
 
         // Set after status is received. Only used for streaming response calls.
-        Nullable<Status> finishedStatus;
+        Status? finishedStatus;
 
         bool readObserverCompleted;  // True if readObserver has already been completed.
 
@@ -64,7 +64,7 @@ namespace Grpc.Core.Internal
             this.finishedHandler = CreateBatchCompletionCallback(HandleFinished);
         }
 
-        public void Initialize(Channel channel, CompletionQueueSafeHandle cq, String methodName)
+        public void Initialize(Channel channel, CompletionQueueSafeHandle cq, string methodName)
         {
             var call = CallSafeHandle.Create(channel.Handle, cq, methodName, channel.Target, Timespec.InfFuture);
             InitializeInternal(call);
@@ -77,7 +77,7 @@ namespace Grpc.Core.Internal
         /// <summary>
         /// Blocking unary request - unary response call.
         /// </summary>
-        public TResponse UnaryCall(Channel channel, String methodName, TRequest msg)
+        public TResponse UnaryCall(Channel channel, string methodName, TRequest msg)
         {
             using (CompletionQueueSafeHandle cq = CompletionQueueSafeHandle.Create())
             {
@@ -264,9 +264,7 @@ namespace Grpc.Core.Internal
 
             if (wasError)
             {
-                unaryResponseTcs.SetException(new RpcException(
-                    new Status(StatusCode.Internal, "Internal error occured.")
-                ));
+                unaryResponseTcs.SetException(new RpcException(new Status(StatusCode.Internal, "Internal error occured.")));
                 return;
             }
 

src/csharp/Grpc.Core/Internal/AsyncCallBase.cs

@@ -302,7 +302,8 @@ namespace Grpc.Core.Internal
         /// </summary>
         protected CompletionCallbackDelegate CreateBatchCompletionCallback(Action<bool, BatchContextSafeHandleNotOwned> handler)
         {
-            return new CompletionCallbackDelegate( (error, batchContextPtr) => {
+            return new CompletionCallbackDelegate((error, batchContextPtr) =>
+            {
                 try
                 {
                     var ctx = new BatchContextSafeHandleNotOwned(batchContextPtr);
@@ -363,7 +364,6 @@ namespace Grpc.Core.Internal
             {
                 FireCompletion(origCompletionDelegate, null);
             }
-           
         }
 
         /// <summary>

src/csharp/Grpc.Core/Internal/AsyncCompletion.cs

@@ -91,5 +91,4 @@ namespace Grpc.Core.Internal
             tcs.SetException(error);
         }
     }
-
 }
\ No newline at end of file

src/csharp/Grpc.Core/Internal/BatchContextSafeHandleNotOwned.cs

@@ -85,11 +85,13 @@ namespace Grpc.Core.Internal
             return data;
         }
 
-        public CallSafeHandle GetServerRpcNewCall() {
+        public CallSafeHandle GetServerRpcNewCall()
+        {
             return grpcsharp_batch_context_server_rpc_new_call(this);
         }
 
-        public string GetServerRpcNewMethod() {
+        public string GetServerRpcNewMethod()
+        {
             return Marshal.PtrToStringAnsi(grpcsharp_batch_context_server_rpc_new_method(this));
         }
     }

src/csharp/Grpc.Core/Internal/CallSafeHandle.cs

@@ -37,12 +37,13 @@ using Grpc.Core;
 namespace Grpc.Core.Internal
 {
     internal delegate void CompletionCallbackDelegate(GRPCOpError error, IntPtr batchContextPtr);
+    
     /// <summary>
     /// grpc_call from <grpc/grpc.h>
     /// </summary>
     internal class CallSafeHandle : SafeHandleZeroIsInvalid
     {
-        const UInt32 GRPC_WRITE_BUFFER_HINT = 1;
+        const uint GRPC_WRITE_BUFFER_HINT = 1;
 
         [DllImport("grpc_csharp_ext.dll")]
         static extern CallSafeHandle grpcsharp_channel_create_call(ChannelSafeHandle channel, CompletionQueueSafeHandle cq, string method, string host, Timespec deadline);
@@ -179,7 +180,7 @@ namespace Grpc.Core.Internal
             Trace.Assert(callError == GRPCCallError.GRPC_CALL_OK, "Status not GRPC_CALL_OK");
         }
 
-        private static UInt32 GetFlags(bool buffered)
+        private static uint GetFlags(bool buffered)
         {
             return buffered ? 0 : GRPC_WRITE_BUFFER_HINT;
         }

src/csharp/Grpc.Core/Internal/ChannelArgsSafeHandle.cs

@@ -74,4 +74,3 @@ namespace Grpc.Core.Internal
         }
     }
 }
-

src/csharp/Grpc.Core/Internal/CompletionQueueSafeHandle.cs

@@ -77,4 +77,3 @@ namespace Grpc.Core.Internal
         }
     }
 }
-