Skip to content
Snippets Groups Projects
Commit 08fef09e authored by Muxi Yan's avatar Muxi Yan
Browse files

Fix minor problems

parent 9ae2a7dc
No related branches found
No related tags found
No related merge requests found
...@@ -96,13 +96,11 @@ ...@@ -96,13 +96,11 @@
switch (newState) { switch (newState) {
case GRXWriterStateFinished: case GRXWriterStateFinished:
self.writeable = nil;
if (_state == GRXWriterStatePaused) { if (_state == GRXWriterStatePaused) {
dispatch_resume(_writeQueue); _writeQueue = nil;
} }
_state = newState; _state = newState;
// Per GRXWriter's contract, setting the state to Finished manually means one doesn't wish the
// writeable to be messaged anymore.
_writeable = nil;
return; return;
case GRXWriterStatePaused: case GRXWriterStatePaused:
if (_state == GRXWriterStateStarted) { if (_state == GRXWriterStateStarted) {
...@@ -124,13 +122,12 @@ ...@@ -124,13 +122,12 @@
- (void)startWithWriteable:(id<GRXWriteable>)writeable { - (void)startWithWriteable:(id<GRXWriteable>)writeable {
_state = GRXWriterStateStarted; _state = GRXWriterStateStarted;
_writeable = writeable; self.writeable = writeable;
dispatch_resume(_writeQueue); dispatch_resume(_writeQueue);
} }
- (void)finishWithError:(NSError *)errorOrNil { - (void)finishWithError:(NSError *)errorOrNil {
id<GRXWriteable> writeable = self.writeable; id<GRXWriteable> writeable = self.writeable;
self.writeable = nil;
self.state = GRXWriterStateFinished; self.state = GRXWriterStateFinished;
dispatch_async(_writeQueue, ^{ dispatch_async(_writeQueue, ^{
[writeable writesFinishedWithError:errorOrNil]; [writeable writesFinishedWithError:errorOrNil];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment