Skip to content
Snippets Groups Projects
Commit 0910e4c0 authored by David Garcia Quintas's avatar David Garcia Quintas
Browse files

pr comments

parent 89d8f169
No related branches found
No related tags found
No related merge requests found
......@@ -69,8 +69,8 @@ int grpc_byte_buffer_reader_init(grpc_byte_buffer_reader *reader,
"Unexpected error decompressing data for algorithm with enum "
"value '%d'. Reading data as if it were uncompressed.",
reader->buffer_in->data.raw.compression);
return 0;
memset(reader, 0, sizeof(*reader));
return 0;
} else { /* all fine */
reader->buffer_out =
grpc_raw_byte_buffer_create(decompressed_slices_buffer.slices,
......
......@@ -253,7 +253,7 @@ GPR_EXPORT intptr_t GPR_CALLTYPE grpcsharp_batch_context_recv_message_length(
if (!ctx->recv_message) {
return -1;
}
/* TODO(dgq): check the return value of grpc_byte_buffer_reader_init. */
/* TODO(issue:#7206): check return value of grpc_byte_buffer_reader_init. */
grpc_byte_buffer_reader_init(&reader, ctx->recv_message);
return (intptr_t)grpc_byte_buffer_length(reader.buffer_out);
}
......@@ -268,7 +268,7 @@ GPR_EXPORT void GPR_CALLTYPE grpcsharp_batch_context_recv_message_to_buffer(
gpr_slice slice;
size_t offset = 0;
/* TODO(dgq): check the return value of grpc_byte_buffer_reader_init. */
/* TODO(issue:#7206): check return value of grpc_byte_buffer_reader_init. */
grpc_byte_buffer_reader_init(&reader, ctx->recv_message);
while (grpc_byte_buffer_reader_next(&reader, &slice)) {
......
......@@ -254,7 +254,8 @@ cdef class ByteBuffer:
cdef void *data_slice_pointer
if self.c_byte_buffer != NULL:
with nogil:
# TODO(dgq): check the return value of grpc_byte_buffer_reader_init.
# TODO(issue:#7205): check the return value of
# grpc_byte_buffer_reader_init.
grpc_byte_buffer_reader_init(&reader, self.c_byte_buffer)
result = bytearray()
with nogil:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment