Skip to content
Snippets Groups Projects
Commit 18de3d72 authored by Vijay Pai's avatar Vijay Pai
Browse files

Make changes suggested by Mark, make this pass sanity

parent 14ea772b
No related branches found
No related tags found
No related merge requests found
...@@ -92,7 +92,7 @@ class combiner { ...@@ -92,7 +92,7 @@ class combiner {
So that explains how combiners work in general. In gRPC, there is So that explains how combiners work in general. In gRPC, there is
`start_batch(..., tag)` and then work only gets activated by somebody `start_batch(..., tag)` and then work only gets activated by somebody
calling `cq::next` which returns a tag. This gives and API-level calling `cq::next` which returns a tag. This gives an API-level
guarantee that there will be a thread doing polling to actually make guarantee that there will be a thread doing polling to actually make
work happen. However, some operations are not covered by a poller work happen. However, some operations are not covered by a poller
thread, such as cancellation that doesn't have a completion. Other thread, such as cancellation that doesn't have a completion. Other
...@@ -128,12 +128,12 @@ tries to spray events onto as many threads as possible to get as much concurrenc ...@@ -128,12 +128,12 @@ tries to spray events onto as many threads as possible to get as much concurrenc
So `offload` really does: So `offload` really does:
``` ```
distributor.run(continue_from_while_loop); workqueue.run(continue_from_while_loop);
break; break;
``` ```
This needs us to add another class variable for a `distributor` This needs us to add another class variable for a `workqueue`
(called a `workqueue` in the code). (which is really conceptually a distributor).
``` ```
workqueue::run(f) { workqueue::run(f) {
......
...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \ ...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
doc/PROTOCOL-WEB.md \ doc/PROTOCOL-WEB.md \
doc/binary-logging.md \ doc/binary-logging.md \
doc/c-style-guide.md \ doc/c-style-guide.md \
doc/combiner-explainer.md \
doc/command_line_tool.md \ doc/command_line_tool.md \
doc/compression.md \ doc/compression.md \
doc/compression_cookbook.md \ doc/compression_cookbook.md \
......
...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \ ...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
doc/PROTOCOL-WEB.md \ doc/PROTOCOL-WEB.md \
doc/binary-logging.md \ doc/binary-logging.md \
doc/c-style-guide.md \ doc/c-style-guide.md \
doc/combiner-explainer.md \
doc/command_line_tool.md \ doc/command_line_tool.md \
doc/compression.md \ doc/compression.md \
doc/compression_cookbook.md \ doc/compression_cookbook.md \
......
...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \ ...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
doc/PROTOCOL-WEB.md \ doc/PROTOCOL-WEB.md \
doc/binary-logging.md \ doc/binary-logging.md \
doc/c-style-guide.md \ doc/c-style-guide.md \
doc/combiner-explainer.md \
doc/command_line_tool.md \ doc/command_line_tool.md \
doc/compression.md \ doc/compression.md \
doc/compression_cookbook.md \ doc/compression_cookbook.md \
......
...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \ ...@@ -764,6 +764,7 @@ INPUT = doc/PROTOCOL-HTTP2.md \
doc/PROTOCOL-WEB.md \ doc/PROTOCOL-WEB.md \
doc/binary-logging.md \ doc/binary-logging.md \
doc/c-style-guide.md \ doc/c-style-guide.md \
doc/combiner-explainer.md \
doc/command_line_tool.md \ doc/command_line_tool.md \
doc/compression.md \ doc/compression.md \
doc/compression_cookbook.md \ doc/compression_cookbook.md \
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment