Skip to content
Snippets Groups Projects
Commit 21e5d2b2 authored by vjpai's avatar vjpai
Browse files

Add a Quit RPC so that we can conveniently shut down the workers from the driver.

parent 0727180d
No related branches found
No related tags found
No related merge requests found
...@@ -150,3 +150,6 @@ message ServerStatus { ...@@ -150,3 +150,6 @@ message ServerStatus {
// Number of cores on the server. See gpr_cpu_num_cores. // Number of cores on the server. See gpr_cpu_num_cores.
int32 cores = 3; int32 cores = 3;
} }
message Void {
}
...@@ -62,4 +62,7 @@ service WorkerService { ...@@ -62,4 +62,7 @@ service WorkerService {
// and once the shutdown has finished, the OK status is sent to terminate // and once the shutdown has finished, the OK status is sent to terminate
// this RPC. // this RPC.
rpc RunClient(stream ClientArgs) returns (stream ClientStatus); rpc RunClient(stream ClientArgs) returns (stream ClientStatus);
// Quit this worker
rpc QuitWorker(Void) returns (Void);
} }
...@@ -283,5 +283,18 @@ std::unique_ptr<ScenarioResult> RunScenario( ...@@ -283,5 +283,18 @@ std::unique_ptr<ScenarioResult> RunScenario(
delete[] servers; delete[] servers;
return result; return result;
} }
void RunQuit() {
// Get client, server lists
auto workers = get_hosts("QPS_WORKERS");
for (size_t i = 0; i < workers.size(); i++) {
auto stub = WorkerService::NewStub(
CreateChannel(workers[i], InsecureChannelCredentials()));
Void dummy;
grpc::ClientContext ctx;
GPR_ASSERT(stub->QuitWorker(&ctx, dummy, &dummy).ok());
}
}
} // namespace testing } // namespace testing
} // namespace grpc } // namespace grpc
...@@ -70,6 +70,7 @@ std::unique_ptr<ScenarioResult> RunScenario( ...@@ -70,6 +70,7 @@ std::unique_ptr<ScenarioResult> RunScenario(
const grpc::testing::ServerConfig& server_config, size_t num_servers, const grpc::testing::ServerConfig& server_config, size_t num_servers,
int warmup_seconds, int benchmark_seconds, int spawn_local_worker_count); int warmup_seconds, int benchmark_seconds, int spawn_local_worker_count);
void RunQuit();
} // namespace testing } // namespace testing
} // namespace grpc } // namespace grpc
......
...@@ -77,6 +77,8 @@ DEFINE_double(pareto_alpha, -1.0, "Pareto alpha value"); ...@@ -77,6 +77,8 @@ DEFINE_double(pareto_alpha, -1.0, "Pareto alpha value");
DEFINE_bool(secure_test, false, "Run a secure test"); DEFINE_bool(secure_test, false, "Run a secure test");
DEFINE_bool(quit, false, "Quit the workers");
using grpc::testing::ClientConfig; using grpc::testing::ClientConfig;
using grpc::testing::ServerConfig; using grpc::testing::ServerConfig;
using grpc::testing::ClientType; using grpc::testing::ClientType;
...@@ -89,6 +91,11 @@ namespace grpc { ...@@ -89,6 +91,11 @@ namespace grpc {
namespace testing { namespace testing {
static void QpsDriver() { static void QpsDriver() {
if (FLAGS_quit) {
RunQuit();
return;
}
RpcType rpc_type; RpcType rpc_type;
GPR_ASSERT(RpcType_Parse(FLAGS_rpc_type, &rpc_type)); GPR_ASSERT(RpcType_Parse(FLAGS_rpc_type, &rpc_type));
......
...@@ -107,8 +107,8 @@ static std::unique_ptr<Server> CreateServer(const ServerConfig& config) { ...@@ -107,8 +107,8 @@ static std::unique_ptr<Server> CreateServer(const ServerConfig& config) {
class WorkerServiceImpl GRPC_FINAL : public WorkerService::Service { class WorkerServiceImpl GRPC_FINAL : public WorkerService::Service {
public: public:
explicit WorkerServiceImpl(int server_port) WorkerServiceImpl(int server_port, QpsWorker *worker)
: acquired_(false), server_port_(server_port) {} : acquired_(false), server_port_(server_port), worker_(worker) {}
Status RunClient(ServerContext* ctx, Status RunClient(ServerContext* ctx,
ServerReaderWriter<ClientStatus, ClientArgs>* stream) ServerReaderWriter<ClientStatus, ClientArgs>* stream)
...@@ -138,6 +138,16 @@ class WorkerServiceImpl GRPC_FINAL : public WorkerService::Service { ...@@ -138,6 +138,16 @@ class WorkerServiceImpl GRPC_FINAL : public WorkerService::Service {
return ret; return ret;
} }
Status QuitWorker(ServerContext *ctx, const Void*, Void*) GRPC_OVERRIDE {
InstanceGuard g(this);
if (!g.Acquired()) {
return Status(StatusCode::RESOURCE_EXHAUSTED, "");
}
worker_->MarkDone();
return Status::OK;
}
private: private:
// Protect against multiple clients using this worker at once. // Protect against multiple clients using this worker at once.
class InstanceGuard { class InstanceGuard {
...@@ -248,10 +258,12 @@ class WorkerServiceImpl GRPC_FINAL : public WorkerService::Service { ...@@ -248,10 +258,12 @@ class WorkerServiceImpl GRPC_FINAL : public WorkerService::Service {
std::mutex mu_; std::mutex mu_;
bool acquired_; bool acquired_;
int server_port_; int server_port_;
QpsWorker *worker_;
}; };
QpsWorker::QpsWorker(int driver_port, int server_port) { QpsWorker::QpsWorker(int driver_port, int server_port) {
impl_.reset(new WorkerServiceImpl(server_port)); impl_.reset(new WorkerServiceImpl(server_port, this));
gpr_atm_rel_store(&done_, static_cast<gpr_atm>(0));
char* server_address = NULL; char* server_address = NULL;
gpr_join_host_port(&server_address, "::", driver_port); gpr_join_host_port(&server_address, "::", driver_port);
...@@ -267,5 +279,11 @@ QpsWorker::QpsWorker(int driver_port, int server_port) { ...@@ -267,5 +279,11 @@ QpsWorker::QpsWorker(int driver_port, int server_port) {
QpsWorker::~QpsWorker() {} QpsWorker::~QpsWorker() {}
bool QpsWorker::Done() const {
return (gpr_atm_acq_load(&done_) != static_cast<gpr_atm>(0));
}
void QpsWorker::MarkDone() {
gpr_atm_rel_store(&done_, static_cast<gpr_atm>(1));
}
} // namespace testing } // namespace testing
} // namespace grpc } // namespace grpc
...@@ -36,6 +36,8 @@ ...@@ -36,6 +36,8 @@
#include <memory> #include <memory>
#include <grpc/support/atm.h>
namespace grpc { namespace grpc {
class Server; class Server;
...@@ -49,9 +51,13 @@ class QpsWorker { ...@@ -49,9 +51,13 @@ class QpsWorker {
explicit QpsWorker(int driver_port, int server_port = 0); explicit QpsWorker(int driver_port, int server_port = 0);
~QpsWorker(); ~QpsWorker();
bool Done() const;
void MarkDone();
private: private:
std::unique_ptr<WorkerServiceImpl> impl_; std::unique_ptr<WorkerServiceImpl> impl_;
std::unique_ptr<Server> server_; std::unique_ptr<Server> server_;
gpr_atm done_;
}; };
} // namespace testing } // namespace testing
......
...@@ -56,7 +56,7 @@ namespace testing { ...@@ -56,7 +56,7 @@ namespace testing {
static void RunServer() { static void RunServer() {
QpsWorker worker(FLAGS_driver_port, FLAGS_server_port); QpsWorker worker(FLAGS_driver_port, FLAGS_server_port);
while (!got_sigint) { while (!got_sigint && !worker.Done()) {
gpr_sleep_until(gpr_time_add(gpr_now(GPR_CLOCK_REALTIME), gpr_sleep_until(gpr_time_add(gpr_now(GPR_CLOCK_REALTIME),
gpr_time_from_seconds(5, GPR_TIMESPAN))); gpr_time_from_seconds(5, GPR_TIMESPAN)));
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment