Skip to content
Snippets Groups Projects
Commit 3e29de19 authored by Julien Boeuf's avatar Julien Boeuf
Browse files

Adressing comments.

parent d1531323
No related branches found
No related tags found
No related merge requests found
...@@ -60,7 +60,7 @@ typedef struct grpc_json { ...@@ -60,7 +60,7 @@ typedef struct grpc_json {
* strings in the tree. The input stream's UTF-8 isn't validated, * strings in the tree. The input stream's UTF-8 isn't validated,
* as in, what you input is what you get as an output. * as in, what you input is what you get as an output.
* *
* All the keys and values in the grpc_json_t objects will be strings * All the keys and values in the grpc_json objects will be strings
* pointing at your input buffer. * pointing at your input buffer.
* *
* Delete the allocated tree afterward using grpc_json_destroy(). * Delete the allocated tree afterward using grpc_json_destroy().
......
...@@ -54,12 +54,16 @@ ...@@ -54,12 +54,16 @@
#define TSI_SSL_MAX_PROTECTED_FRAME_SIZE_UPPER_BOUND 16384 #define TSI_SSL_MAX_PROTECTED_FRAME_SIZE_UPPER_BOUND 16384
#define TSI_SSL_MAX_PROTECTED_FRAME_SIZE_LOWER_BOUND 1024 #define TSI_SSL_MAX_PROTECTED_FRAME_SIZE_LOWER_BOUND 1024
/* Putting a macro like this and littering the source file with #if is really
bad practice.
TODO(jboeuf): refactor all the #if / #endif in a separate module. */
#ifndef TSI_OPENSSL_ALPN_SUPPORT #ifndef TSI_OPENSSL_ALPN_SUPPORT
#define TSI_OPENSSL_ALPN_SUPPORT 1 #define TSI_OPENSSL_ALPN_SUPPORT 1
#endif #endif
/* TODO(jboeuf): I have not found a way to get this number dynamically from the /* TODO(jboeuf): I have not found a way to get this number dynamically from the
* SSL structure. This is what we would ultimately want though... */ SSL structure. This is what we would ultimately want though... */
#define TSI_SSL_MAX_PROTECTION_OVERHEAD 100 #define TSI_SSL_MAX_PROTECTION_OVERHEAD 100
/* --- Structure definitions. ---*/ /* --- Structure definitions. ---*/
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment