Skip to content
Snippets Groups Projects
Commit 3eb403f4 authored by Jan Tattermusch's avatar Jan Tattermusch
Browse files

Revert "Refactor C# building in run_tests.py"

parent 981bfb0f
No related branches found
No related tags found
No related merge requests found
...@@ -120,12 +120,7 @@ def get_c_tests(travis, test_lang) : ...@@ -120,12 +120,7 @@ def get_c_tests(travis, test_lang) :
def _check_compiler(compiler, supported_compilers): def _check_compiler(compiler, supported_compilers):
if compiler not in supported_compilers: if compiler not in supported_compilers:
raise Exception('Compiler %s not supported (on this platform).' % compiler) raise Exception('Compiler %s not supported.' % compiler)
def _check_arch(arch, supported_archs):
if arch not in supported_archs:
raise Exception('Architecture %s not supported.' % arch)
def _is_use_docker_child(): def _is_use_docker_child():
...@@ -469,19 +464,7 @@ class CSharpLanguage(object): ...@@ -469,19 +464,7 @@ class CSharpLanguage(object):
def configure(self, config, args): def configure(self, config, args):
self.config = config self.config = config
self.args = args self.args = args
if self.platform == 'windows': _check_compiler(self.args.compiler, ['default'])
# Explicitly choosing between x86 and x64 arch doesn't work yet
_check_arch(self.args.arch, ['default'])
self._make_options = [_windows_toolset_option(self.args.compiler),
_windows_arch_option(self.args.arch)]
else:
_check_compiler(self.args.compiler, ['default'])
if self.platform == 'mac':
# On Mac, official distribution of mono is 32bit.
self._make_options = ['EMBED_OPENSSL=true', 'EMBED_ZLIB=true',
'CFLAGS=-arch i386', 'LDFLAGS=-arch i386']
else:
self._make_options = ['EMBED_OPENSSL=true', 'EMBED_ZLIB=true']
def test_specs(self): def test_specs(self):
with open('src/csharp/tests.json') as f: with open('src/csharp/tests.json') as f:
...@@ -528,16 +511,23 @@ class CSharpLanguage(object): ...@@ -528,16 +511,23 @@ class CSharpLanguage(object):
return [['tools/run_tests/pre_build_csharp.sh']] return [['tools/run_tests/pre_build_csharp.sh']]
def make_targets(self): def make_targets(self):
return ['grpc_csharp_ext'] # For Windows, this target doesn't really build anything,
# everything is build by buildall script later.
if self.platform == 'windows':
return []
else:
return ['grpc_csharp_ext']
def make_options(self): def make_options(self):
return self._make_options; if self.platform == 'mac':
# On Mac, official distribution of mono is 32bit.
return ['CFLAGS=-arch i386', 'LDFLAGS=-arch i386']
else:
return []
def build_steps(self): def build_steps(self):
if self.platform == 'windows': if self.platform == 'windows':
return [[_windows_build_bat(self.args.compiler), return [['src\\csharp\\buildall.bat']]
'src/csharp/Grpc.sln',
'/p:Configuration=%s' % _MSBUILD_CONFIG[self.config.build_config]]]
else: else:
return [['tools/run_tests/build_csharp.sh']] return [['tools/run_tests/build_csharp.sh']]
......
@rem Convenience wrapper that runs specified gRPC target using msbuild @rem Convenience wrapper that runs specified gRPC target using msbuild
@rem Usage: build_vs2010.bat TARGET_NAME @rem Usage: build.bat TARGET_NAME
setlocal setlocal
@rem Set VS variables (uses Visual Studio 2010) @rem Set VS variables (uses Visual Studio 2010)
......
@rem Convenience wrapper that runs specified gRPC target using msbuild @rem Convenience wrapper that runs specified gRPC target using msbuild
@rem Usage: build_vs2013.bat TARGET_NAME @rem Usage: build.bat TARGET_NAME
setlocal setlocal
@rem Set VS variables (uses Visual Studio 2013) @rem Set VS variables (uses Visual Studio 2013)
......
@rem Convenience wrapper that runs specified gRPC target using msbuild @rem Convenience wrapper that runs specified gRPC target using msbuild
@rem Usage: build_vs2015.bat TARGET_NAME @rem Usage: build.bat TARGET_NAME
setlocal setlocal
@rem Set VS variables (uses Visual Studio 2015) @rem Set VS variables (uses Visual Studio 2015)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment