Skip to content
Snippets Groups Projects
Commit 41559c64 authored by Yang Gao's avatar Yang Gao Committed by GitHub
Browse files

Merge pull request #10024 from grpc/revert-10015-use_after_free

Revert "Fix flaky use-after-free in udp_server"
parents 73c33541 7c1aafb3
No related branches found
No related tags found
No related merge requests found
...@@ -485,11 +485,7 @@ void grpc_udp_server_start(grpc_exec_ctx *exec_ctx, grpc_udp_server *s, ...@@ -485,11 +485,7 @@ void grpc_udp_server_start(grpc_exec_ctx *exec_ctx, grpc_udp_server *s,
grpc_schedule_on_exec_ctx); grpc_schedule_on_exec_ctx);
grpc_fd_notify_on_write(exec_ctx, sp->emfd, &sp->write_closure); grpc_fd_notify_on_write(exec_ctx, sp->emfd, &sp->write_closure);
/* Registered for both read and write callbacks: increment active_ports s->active_ports++;
* twice to account for this, and delay free-ing of memory until both
* on_read and on_write have fired. */
s->active_ports += 2;
sp = sp->next; sp = sp->next;
} }
......
Subproject commit f8a0efe03aa69b3336d8e228b37d4ccb17324b88 Subproject commit 30dbc81fb5ffdc98ea9b14b1918bfe4e8779b26e
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment