Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
43f18f3b
Commit
43f18f3b
authored
9 years ago
by
Craig Tiller
Browse files
Options
Downloads
Plain Diff
Merge pull request #1330 from yang-g/bugfix
Remove an extra unref
parents
a2f63bb6
3b3097fb
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/cpp/util/byte_buffer.cc
+0
-1
0 additions, 1 deletion
src/cpp/util/byte_buffer.cc
test/cpp/end2end/generic_end2end_test.cc
+2
-1
2 additions, 1 deletion
test/cpp/end2end/generic_end2end_test.cc
with
2 additions
and
2 deletions
src/cpp/util/byte_buffer.cc
+
0
−
1
View file @
43f18f3b
...
@@ -60,7 +60,6 @@ void ByteBuffer::Dump(std::vector<Slice>* slices) {
...
@@ -60,7 +60,6 @@ void ByteBuffer::Dump(std::vector<Slice>* slices) {
gpr_slice
s
;
gpr_slice
s
;
while
(
grpc_byte_buffer_reader_next
(
reader
,
&
s
))
{
while
(
grpc_byte_buffer_reader_next
(
reader
,
&
s
))
{
slices
->
push_back
(
Slice
(
s
,
Slice
::
STEAL_REF
));
slices
->
push_back
(
Slice
(
s
,
Slice
::
STEAL_REF
));
gpr_slice_unref
(
s
);
}
}
grpc_byte_buffer_reader_destroy
(
reader
);
grpc_byte_buffer_reader_destroy
(
reader
);
}
}
...
...
This diff is collapsed.
Click to expand it.
test/cpp/end2end/generic_end2end_test.cc
+
2
−
1
View file @
43f18f3b
...
@@ -149,7 +149,8 @@ class GenericEnd2endTest : public ::testing::Test {
...
@@ -149,7 +149,8 @@ class GenericEnd2endTest : public ::testing::Test {
GenericServerContext
srv_ctx
;
GenericServerContext
srv_ctx
;
GenericServerAsyncReaderWriter
stream
(
&
srv_ctx
);
GenericServerAsyncReaderWriter
stream
(
&
srv_ctx
);
send_request
.
set_message
(
"Hello"
);
// The string needs to be long enough to test heap-based slice.
send_request
.
set_message
(
"Hello world. Hello world. Hello world."
);
std
::
unique_ptr
<
GenericClientAsyncReaderWriter
>
call
=
std
::
unique_ptr
<
GenericClientAsyncReaderWriter
>
call
=
generic_stub_
->
Call
(
&
cli_ctx
,
kMethodName
,
&
cli_cq_
,
tag
(
1
));
generic_stub_
->
Call
(
&
cli_ctx
,
kMethodName
,
&
cli_cq_
,
tag
(
1
));
client_ok
(
1
);
client_ok
(
1
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment