Skip to content
Snippets Groups Projects
Commit 474f53b1 authored by murgatroid99's avatar murgatroid99
Browse files

Fixed Op destructors not being called

parent e8659971
No related branches found
No related tags found
No related merge requests found
......@@ -172,6 +172,9 @@ Handle<Value> Op::GetOpType() const {
return NanEscapeScope(NanNew<String>(GetTypeString()));
}
Op::~Op() {
}
class SendMetadataOp : public Op {
public:
Handle<Value> GetNodeValue() const {
......@@ -325,7 +328,7 @@ class ReadMessageOp : public Op {
}
~ReadMessageOp() {
if (recv_message != NULL) {
gpr_free(recv_message);
grpc_byte_buffer_destroy(recv_message);
}
}
Handle<Value> GetNodeValue() const {
......
......@@ -88,6 +88,7 @@ struct Resources {
class Op {
public:
virtual ~Op();
virtual v8::Handle<v8::Value> GetNodeValue() const = 0;
virtual bool ParseOp(v8::Handle<v8::Value> value, grpc_op *out,
shared_ptr<Resources> resources) = 0;
......@@ -98,7 +99,6 @@ class Op {
};
typedef std::vector<unique_ptr<Op>> OpVec;
struct tag {
tag(NanCallback *callback, OpVec *ops,
shared_ptr<Resources> resources);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment