Skip to content
Snippets Groups Projects
Commit 4be94b95 authored by Chilledheart's avatar Chilledheart
Browse files

Add missing GRPC_OVERRIDE, NFC

Testing asan configuration with the latest clang compiler fails due to
the warning `-Winconsistent-missing-override`. This patch fixes it.
parent 75c60c1a
No related branches found
No related tags found
No related merge requests found
...@@ -92,7 +92,7 @@ class ServerAsyncResponseWriter GRPC_FINAL ...@@ -92,7 +92,7 @@ class ServerAsyncResponseWriter GRPC_FINAL
explicit ServerAsyncResponseWriter(ServerContext* ctx) explicit ServerAsyncResponseWriter(ServerContext* ctx)
: call_(nullptr, nullptr, nullptr), ctx_(ctx) {} : call_(nullptr, nullptr, nullptr), ctx_(ctx) {}
void SendInitialMetadata(void* tag) { void SendInitialMetadata(void* tag) GRPC_OVERRIDE {
GPR_ASSERT(!ctx_->sent_initial_metadata_); GPR_ASSERT(!ctx_->sent_initial_metadata_);
meta_buf_.Reset(tag); meta_buf_.Reset(tag);
......
...@@ -96,7 +96,7 @@ class Server GRPC_FINAL : private CallHook, ...@@ -96,7 +96,7 @@ class Server GRPC_FINAL : private CallHook,
void RequestAsyncCall(void* registered_method, ServerContext* context, void RequestAsyncCall(void* registered_method, ServerContext* context,
grpc::protobuf::Message* request, grpc::protobuf::Message* request,
ServerAsyncStreamingInterface* stream, ServerAsyncStreamingInterface* stream,
CompletionQueue* cq, void* tag); CompletionQueue* cq, void* tag) GRPC_OVERRIDE;
// Completion queue. // Completion queue.
CompletionQueue cq_; CompletionQueue cq_;
......
...@@ -94,7 +94,7 @@ class ClientRpcContextUnaryImpl : public ClientRpcContext { ...@@ -94,7 +94,7 @@ class ClientRpcContextUnaryImpl : public ClientRpcContext {
hist->Add((Timer::Now() - start_) * 1e9); hist->Add((Timer::Now() - start_) * 1e9);
} }
void StartNewClone() { void StartNewClone() GRPC_OVERRIDE {
new ClientRpcContextUnaryImpl(stub_, req_, start_req_, callback_); new ClientRpcContextUnaryImpl(stub_, req_, start_req_, callback_);
} }
...@@ -175,7 +175,7 @@ class AsyncClient GRPC_FINAL : public Client { ...@@ -175,7 +175,7 @@ class AsyncClient GRPC_FINAL : public Client {
} }
} }
void ThreadFunc(Histogram *histogram, size_t thread_idx) { void ThreadFunc(Histogram *histogram, size_t thread_idx) GRPC_OVERRIDE {
void *got_tag; void *got_tag;
bool ok; bool ok;
cli_cqs_[thread_idx]->Next(&got_tag, &ok); cli_cqs_[thread_idx]->Next(&got_tag, &ok);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment