Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
4cdcd12f
Commit
4cdcd12f
authored
8 years ago
by
Mark D. Roth
Browse files
Options
Downloads
Patches
Plain Diff
Fix locking bug in HTTP CONNECT handshaker.
parent
09ee8d02
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/core/ext/client_channel/http_connect_handshaker.c
+1
-2
1 addition, 2 deletions
src/core/ext/client_channel/http_connect_handshaker.c
with
1 addition
and
2 deletions
src/core/ext/client_channel/http_connect_handshaker.c
+
1
−
2
View file @
4cdcd12f
...
@@ -86,9 +86,9 @@ static void http_connect_handshaker_unref(http_connect_handshaker* handshaker) {
...
@@ -86,9 +86,9 @@ static void http_connect_handshaker_unref(http_connect_handshaker* handshaker) {
static
void
on_write_done
(
grpc_exec_ctx
*
exec_ctx
,
void
*
arg
,
static
void
on_write_done
(
grpc_exec_ctx
*
exec_ctx
,
void
*
arg
,
grpc_error
*
error
)
{
grpc_error
*
error
)
{
http_connect_handshaker
*
handshaker
=
arg
;
http_connect_handshaker
*
handshaker
=
arg
;
gpr_mu_lock
(
&
handshaker
->
mu
);
if
(
error
!=
GRPC_ERROR_NONE
||
handshaker
->
args
==
NULL
)
{
if
(
error
!=
GRPC_ERROR_NONE
||
handshaker
->
args
==
NULL
)
{
// If the write failed, invoke the callback immediately with the error.
// If the write failed, invoke the callback immediately with the error.
gpr_mu_lock
(
&
handshaker
->
mu
);
grpc_exec_ctx_sched
(
exec_ctx
,
handshaker
->
on_handshake_done
,
grpc_exec_ctx_sched
(
exec_ctx
,
handshaker
->
on_handshake_done
,
GRPC_ERROR_REF
(
error
),
NULL
);
GRPC_ERROR_REF
(
error
),
NULL
);
handshaker
->
args
=
NULL
;
handshaker
->
args
=
NULL
;
...
@@ -97,7 +97,6 @@ static void on_write_done(grpc_exec_ctx* exec_ctx, void* arg,
...
@@ -97,7 +97,6 @@ static void on_write_done(grpc_exec_ctx* exec_ctx, void* arg,
}
else
{
}
else
{
// Otherwise, read the response.
// Otherwise, read the response.
// The read callback inherits our ref to the handshaker.
// The read callback inherits our ref to the handshaker.
gpr_mu_lock
(
&
handshaker
->
mu
);
grpc_endpoint_read
(
exec_ctx
,
handshaker
->
args
->
endpoint
,
grpc_endpoint_read
(
exec_ctx
,
handshaker
->
args
->
endpoint
,
handshaker
->
args
->
read_buffer
,
handshaker
->
args
->
read_buffer
,
&
handshaker
->
response_read_closure
);
&
handshaker
->
response_read_closure
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment