Skip to content
Snippets Groups Projects
Commit 4f11ab1f authored by Makarand Dharmapurikar's avatar Makarand Dharmapurikar
Browse files

addressed feedback.

parent 6f950109
No related branches found
No related tags found
No related merge requests found
...@@ -94,7 +94,7 @@ void PrintSimpleSignature(Printer *printer, const MethodDescriptor *method, ...@@ -94,7 +94,7 @@ void PrintSimpleSignature(Printer *printer, const MethodDescriptor *method,
void PrintAdvancedSignature(Printer *printer, const MethodDescriptor *method, void PrintAdvancedSignature(Printer *printer, const MethodDescriptor *method,
map< ::grpc::string, ::grpc::string> vars) { map< ::grpc::string, ::grpc::string> vars) {
vars["method_name"] = "RPCTo" + vars["method_name"]; vars["method_name"] = "RPCTo" + vars["method_name"];
vars["return_type"] = "GRPCProtoRPC *"; vars["return_type"] = "GRPCProtoCall *";
PrintMethodSignature(printer, method, vars); PrintMethodSignature(printer, method, vars);
} }
......
...@@ -51,7 +51,7 @@ __attribute__((deprecated("Please use GRPCProtoMethod."))) ...@@ -51,7 +51,7 @@ __attribute__((deprecated("Please use GRPCProtoMethod.")))
@end @end
/** /**
* This subclass is empty now. Eventually we'll remove ProtoService class * This subclass is empty now. Eventually we'll remove ProtoMethod class
* to avoid potential naming conflict * to avoid potential naming conflict
*/ */
@interface GRPCProtoMethod : ProtoMethod @interface GRPCProtoMethod : ProtoMethod
......
...@@ -36,7 +36,7 @@ ...@@ -36,7 +36,7 @@
#import "ProtoMethod.h" #import "ProtoMethod.h"
__attribute__((deprecated("Please use GRPCProtoRPC."))) __attribute__((deprecated("Please use GRPCProtoCall.")))
@interface ProtoRPC : GRPCCall @interface ProtoRPC : GRPCCall
- (instancetype)initWithHost:(NSString *)host - (instancetype)initWithHost:(NSString *)host
...@@ -49,9 +49,9 @@ __attribute__((deprecated("Please use GRPCProtoRPC."))) ...@@ -49,9 +49,9 @@ __attribute__((deprecated("Please use GRPCProtoRPC.")))
@end @end
/** /**
* This subclass is empty now. Eventually we'll remove ProtoService class * This subclass is empty now. Eventually we'll remove ProtoRPC class
* to avoid potential naming conflict * to avoid potential naming conflict
*/ */
@interface GRPCProtoRPC : ProtoRPC @interface GRPCProtoCall : ProtoRPC
@end @end
...@@ -118,6 +118,6 @@ static NSError *ErrorForBadProto(id proto, Class expectedClass, NSError *parsing ...@@ -118,6 +118,6 @@ static NSError *ErrorForBadProto(id proto, Class expectedClass, NSError *parsing
} }
@end @end
@implementation GRPCProtoRPC @implementation GRPCProtoCall
@end @end
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
@class GRPCProtoRPC; @class GRPCProtoCall;
@protocol GRXWriteable; @protocol GRXWriteable;
@class GRXWriter; @class GRXWriter;
...@@ -44,7 +44,7 @@ __attribute__((deprecated("Please use GRPCProtoService."))) ...@@ -44,7 +44,7 @@ __attribute__((deprecated("Please use GRPCProtoService.")))
packageName:(NSString *)packageName packageName:(NSString *)packageName
serviceName:(NSString *)serviceName NS_DESIGNATED_INITIALIZER; serviceName:(NSString *)serviceName NS_DESIGNATED_INITIALIZER;
- (GRPCProtoRPC *)RPCToMethod:(NSString *)method - (GRPCProtoCall *)RPCToMethod:(NSString *)method
requestsWriter:(GRXWriter *)requestsWriter requestsWriter:(GRXWriter *)requestsWriter
responseClass:(Class)responseClass responseClass:(Class)responseClass
responsesWriteable:(id<GRXWriteable>)responsesWriteable; responsesWriteable:(id<GRXWriteable>)responsesWriteable;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment