Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
68309b42
Commit
68309b42
authored
7 years ago
by
Matt Kwong
Browse files
Options
Downloads
Patches
Plain Diff
Add test to check if bazel subdirectory was modified
parent
18528f28
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
tools/jenkins/run_bazel_full.sh
+2
-0
2 additions, 0 deletions
tools/jenkins/run_bazel_full.sh
tools/run_tests/python_utils/check_bazel_dir.py
+41
-0
41 additions, 0 deletions
tools/run_tests/python_utils/check_bazel_dir.py
with
43 additions
and
0 deletions
tools/jenkins/run_bazel_full.sh
+
2
−
0
View file @
68309b42
...
...
@@ -20,4 +20,6 @@ set -ex -o igncr || set -ex
export
DOCKERFILE_DIR
=
tools/dockerfile/test/bazel
export
DOCKER_RUN_SCRIPT
=
tools/jenkins/run_bazel_full_in_docker.sh
# Warn PR author if they make a change to the bazel directory
tools/run_tests/python_utils/check_bazel_dir.py
exec
tools/run_tests/dockerize/build_and_run_docker.sh
This diff is collapsed.
Click to expand it.
tools/run_tests/python_utils/check_bazel_dir.py
0 → 100755
+
41
−
0
View file @
68309b42
#!/usr/bin/env python
# Copyright 2017 gRPC authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""
This sends out a warning if any changes to the bazel dir are made.
"""
from
__future__
import
print_function
from
subprocess
import
check_output
import
comment_on_pr
import
os
_WARNING_MESSAGE
=
'
WARNING: You are making changes in the Bazel subdirectory.
'
\
'
Please get explicit approval from @nicolasnoble before merging.
'
def
_get_changed_files
(
base_branch
):
"""
Get list of changed files between current branch and base of target merge branch
"""
# Get file changes between branch and merge-base of specified branch
base_commit
=
check_output
([
"
git
"
,
"
merge-base
"
,
base_branch
,
"
HEAD
"
]).
rstrip
()
return
check_output
([
"
git
"
,
"
diff
"
,
base_commit
,
"
--name-only
"
]).
splitlines
()
# ghprbTargetBranch environment variable only available during a Jenkins PR tests
if
'
ghprbTargetBranch
'
in
os
.
environ
:
changed_files
=
_get_changed_files
(
'
origin/%s
'
%
os
.
environ
[
'
ghprbTargetBranch
'
])
if
any
(
file
.
startswith
(
'
bazel/
'
)
for
file
in
changed_files
):
comment_on_pr
.
comment_on_pr
(
_WARNING_MESSAGE
)
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment