Skip to content
Snippets Groups Projects
Commit 69719089 authored by Alexander Polcyn's avatar Alexander Polcyn
Browse files

remove a TODO

parent b7e1f535
No related branches found
No related tags found
No related merge requests found
...@@ -416,10 +416,10 @@ static void grpc_rb_channel_safe_destroy(grpc_rb_channel *wrapper) { ...@@ -416,10 +416,10 @@ static void grpc_rb_channel_safe_destroy(grpc_rb_channel *wrapper) {
grpc_channel_destroy(wrapper->wrapped); grpc_channel_destroy(wrapper->wrapped);
} }
// Note this loop breaks out when a single call of // Note this loop breaks out with a single call of
// "grpc_rb_event_unblocking_func". // "grpc_rb_event_unblocking_func".
// TODO (apolcyn) does a ruby call to the unblocking func // This assumes that a ruby call the unblocking func
// necesarily mean process shutdown? // indicates process shutdown.
// In the worst case, this stops polling channel connectivity // In the worst case, this stops polling channel connectivity
// early and falls back to current behavior. // early and falls back to current behavior.
static void *run_poll_channels_loop_no_gil(void *arg) { static void *run_poll_channels_loop_no_gil(void *arg) {
...@@ -430,7 +430,6 @@ static void *run_poll_channels_loop_no_gil(void *arg) { ...@@ -430,7 +430,6 @@ static void *run_poll_channels_loop_no_gil(void *arg) {
event = grpc_completion_queue_next( event = grpc_completion_queue_next(
channel_polling_cq, gpr_inf_future(GPR_CLOCK_REALTIME), NULL); channel_polling_cq, gpr_inf_future(GPR_CLOCK_REALTIME), NULL);
if (event.type == GRPC_QUEUE_SHUTDOWN) { if (event.type == GRPC_QUEUE_SHUTDOWN) {
// TODO (apolcyn) is it guaranteed that this cq is empty by now?
break; break;
} }
if (event.type == GRPC_OP_COMPLETE) { if (event.type == GRPC_OP_COMPLETE) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment