Skip to content
Snippets Groups Projects
Commit 69d500d2 authored by David G. Quintas's avatar David G. Quintas
Browse files

Merge pull request #3081 from ctiller/under-pressure

Up asan/tsan timeouts - they need it
parents 33c9c1f6 b2ea0b9f
No related branches found
No related tags found
No related merge requests found
...@@ -174,7 +174,6 @@ class Job(object): ...@@ -174,7 +174,6 @@ class Job(object):
for k, v in add_env.iteritems(): for k, v in add_env.iteritems():
env[k] = v env[k] = v
self._start = time.time() self._start = time.time()
print spec.cmdline
self._process = subprocess.Popen(args=spec.cmdline, self._process = subprocess.Popen(args=spec.cmdline,
stderr=subprocess.STDOUT, stderr=subprocess.STDOUT,
stdout=self._tempfile, stdout=self._tempfile,
......
...@@ -70,13 +70,14 @@ def platform_string(): ...@@ -70,13 +70,14 @@ def platform_string():
# SimpleConfig: just compile with CONFIG=config, and run the binary to test # SimpleConfig: just compile with CONFIG=config, and run the binary to test
class SimpleConfig(object): class SimpleConfig(object):
def __init__(self, config, environ=None): def __init__(self, config, environ=None, timeout_seconds=5*60):
if environ is None: if environ is None:
environ = {} environ = {}
self.build_config = config self.build_config = config
self.allow_hashing = (config != 'gcov') self.allow_hashing = (config != 'gcov')
self.environ = environ self.environ = environ
self.environ['CONFIG'] = config self.environ['CONFIG'] = config
self.timeout_seconds = timeout_seconds
def job_spec(self, cmdline, hash_targets, shortname=None, environ={}): def job_spec(self, cmdline, hash_targets, shortname=None, environ={}):
"""Construct a jobset.JobSpec for a test under this config """Construct a jobset.JobSpec for a test under this config
...@@ -96,6 +97,7 @@ class SimpleConfig(object): ...@@ -96,6 +97,7 @@ class SimpleConfig(object):
return jobset.JobSpec(cmdline=cmdline, return jobset.JobSpec(cmdline=cmdline,
shortname=shortname, shortname=shortname,
environ=actual_environ, environ=actual_environ,
timeout_seconds=self.timeout_seconds,
hash_targets=hash_targets hash_targets=hash_targets
if self.allow_hashing else None) if self.allow_hashing else None)
...@@ -354,11 +356,11 @@ class Build(object): ...@@ -354,11 +356,11 @@ class Build(object):
_CONFIGS = { _CONFIGS = {
'dbg': SimpleConfig('dbg'), 'dbg': SimpleConfig('dbg'),
'opt': SimpleConfig('opt'), 'opt': SimpleConfig('opt'),
'tsan': SimpleConfig('tsan', environ={ 'tsan': SimpleConfig('tsan', timeout_seconds=10*60, environ={
'TSAN_OPTIONS': 'suppressions=tools/tsan_suppressions.txt:halt_on_error=1:second_deadlock_stack=1'}), 'TSAN_OPTIONS': 'suppressions=tools/tsan_suppressions.txt:halt_on_error=1:second_deadlock_stack=1'}),
'msan': SimpleConfig('msan'), 'msan': SimpleConfig('msan'),
'ubsan': SimpleConfig('ubsan'), 'ubsan': SimpleConfig('ubsan'),
'asan': SimpleConfig('asan', environ={ 'asan': SimpleConfig('asan', timeout_seconds=7*60, environ={
'ASAN_OPTIONS': 'detect_leaks=1:color=always:suppressions=tools/tsan_suppressions.txt', 'ASAN_OPTIONS': 'detect_leaks=1:color=always:suppressions=tools/tsan_suppressions.txt',
'LSAN_OPTIONS': 'report_objects=1'}), 'LSAN_OPTIONS': 'report_objects=1'}),
'asan-noleaks': SimpleConfig('asan', environ={ 'asan-noleaks': SimpleConfig('asan', environ={
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment