Skip to content
Snippets Groups Projects
Commit 7ce14d2a authored by Mark D. Roth's avatar Mark D. Roth
Browse files

Code review changes.

parent 2b626466
No related branches found
No related tags found
No related merge requests found
...@@ -63,8 +63,9 @@ void grpc_lb_addresses_destroy(grpc_lb_addresses* addresses, ...@@ -63,8 +63,9 @@ void grpc_lb_addresses_destroy(grpc_lb_addresses* addresses,
void (*user_data_destroy)(void*)) { void (*user_data_destroy)(void*)) {
for (size_t i = 0; i < addresses->num_addresses; ++i) { for (size_t i = 0; i < addresses->num_addresses; ++i) {
gpr_free(addresses->addresses[i].balancer_name); gpr_free(addresses->addresses[i].balancer_name);
if (user_data_destroy != NULL) if (user_data_destroy != NULL) {
user_data_destroy(addresses->addresses[i].user_data); user_data_destroy(addresses->addresses[i].user_data);
}
} }
gpr_free(addresses->addresses); gpr_free(addresses->addresses);
gpr_free(addresses); gpr_free(addresses);
......
...@@ -354,8 +354,7 @@ static bool is_server_valid(const grpc_grpclb_server *server, size_t idx, ...@@ -354,8 +354,7 @@ static bool is_server_valid(const grpc_grpclb_server *server, size_t idx,
return true; return true;
} }
/* populate \a addresses according to \a serverlist. Returns the number of /* Returns addresses extracted from \a serverlist. */
* addresses successfully parsed and added to \a addresses */
static grpc_lb_addresses *process_serverlist( static grpc_lb_addresses *process_serverlist(
const grpc_grpclb_serverlist *serverlist) { const grpc_grpclb_serverlist *serverlist) {
size_t num_valid = 0; size_t num_valid = 0;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment