Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
7e90745b
Commit
7e90745b
authored
9 years ago
by
Jorge Canizales
Browse files
Options
Downloads
Patches
Plain Diff
Document plan to merge the GRPCChannel subclasses
parent
77723b12
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/objective-c/GRPCClient/private/GRPCSecureChannel.m
+2
-0
2 additions, 0 deletions
src/objective-c/GRPCClient/private/GRPCSecureChannel.m
src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m
+2
-0
2 additions, 0 deletions
src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m
with
4 additions
and
0 deletions
src/objective-c/GRPCClient/private/GRPCSecureChannel.m
+
2
−
0
View file @
7e90745b
...
...
@@ -102,6 +102,8 @@ static grpc_credentials *CertificatesAtPath(NSString *path, NSError **errorPtr)
[
super
initWithChannel
:
grpc_secure_channel_create
(
credentials
,
host
.
UTF8String
,
args
)]);
}
// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers
// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary.
-
(
instancetype
)
initWithChannel
:(
grpc_channel
*
)
unmanagedChannel
{
[
NSException
raise
:
NSInternalInconsistencyException
format
:
@"use another initializer"
];
return
[
self
initWithHost
:
nil
];
// silence warnings
...
...
This diff is collapsed.
Click to expand it.
src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m
+
2
−
0
View file @
7e90745b
...
...
@@ -41,6 +41,8 @@
return
(
self
=
[
super
initWithChannel
:
grpc_insecure_channel_create
(
host
.
UTF8String
,
NULL
)]);
}
// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers
// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary.
-
(
instancetype
)
initWithChannel
:(
grpc_channel
*
)
unmanagedChannel
{
[
NSException
raise
:
NSInternalInconsistencyException
format
:
@"use the other initializer"
];
return
[
self
initWithHost
:
nil
];
// silence warnings
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment