Skip to content
Snippets Groups Projects
Commit 7e90745b authored by Jorge Canizales's avatar Jorge Canizales
Browse files

Document plan to merge the GRPCChannel subclasses

parent 77723b12
No related branches found
No related tags found
No related merge requests found
......@@ -102,6 +102,8 @@ static grpc_credentials *CertificatesAtPath(NSString *path, NSError **errorPtr)
[super initWithChannel:grpc_secure_channel_create(credentials, host.UTF8String, args)]);
}
// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers
// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary.
- (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel {
[NSException raise:NSInternalInconsistencyException format:@"use another initializer"];
return [self initWithHost:nil]; // silence warnings
......
......@@ -41,6 +41,8 @@
return (self = [super initWithChannel:grpc_insecure_channel_create(host.UTF8String, NULL)]);
}
// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers
// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary.
- (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel {
[NSException raise:NSInternalInconsistencyException format:@"use the other initializer"];
return [self initWithHost:nil]; // silence warnings
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment