Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
804b8553
Commit
804b8553
authored
9 years ago
by
Craig Tiller
Browse files
Options
Downloads
Patches
Plain Diff
Test for a working -Wshadow
parent
b79c1e11
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
Makefile
+7
-1
7 additions, 1 deletion
Makefile
templates/Makefile.template
+7
-1
7 additions, 1 deletion
templates/Makefile.template
test/build/boringssl.c
+1
-0
1 addition, 0 deletions
test/build/boringssl.c
test/build/shadow.c
+43
-0
43 additions, 0 deletions
test/build/shadow.c
with
58 additions
and
2 deletions
Makefile
+
7
−
1
View file @
804b8553
...
@@ -275,6 +275,12 @@ endif
...
@@ -275,6 +275,12 @@ endif
CXX11_CHECK_CMD = $(CXX) -std=c++11 -o $(TMPOUT) -c test/build/c++11.cc
CXX11_CHECK_CMD = $(CXX) -std=c++11 -o $(TMPOUT) -c test/build/c++11.cc
HAS_CXX11 = $(shell $(CXX11_CHECK_CMD) 2> /dev/null && echo true || echo false)
HAS_CXX11 = $(shell $(CXX11_CHECK_CMD) 2> /dev/null && echo true || echo false)
CHECK_SHADOW_WORKS_CMD = $(CC) -std=c99 -Werror -Wshadow -o $(TMPOUT) -c test/build/shadow.c
HAS_WORKING_SHADOW = $(shell $(CHECK_SHADOW_WORKS_CMD) 2> /dev/null && echo true || echo false)
ifeq ($(HAS_WORKING_SHADOW),true)
W_SHADOW=-Wshadow
endif
CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD = $(CC) -std=c99 -Werror -Wno-shift-negative-value -o $(TMPOUT) -c test/build/empty.c
CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD = $(CC) -std=c99 -Werror -Wno-shift-negative-value -o $(TMPOUT) -c test/build/empty.c
HAS_NO_SHIFT_NEGATIVE_VALUE = $(shell $(CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD) 2> /dev/null && echo true || echo false)
HAS_NO_SHIFT_NEGATIVE_VALUE = $(shell $(CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD) 2> /dev/null && echo true || echo false)
ifeq ($(HAS_NO_SHIFT_NEGATIVE_VALUE),true)
ifeq ($(HAS_NO_SHIFT_NEGATIVE_VALUE),true)
...
@@ -295,7 +301,7 @@ ifdef EXTRA_DEFINES
...
@@ -295,7 +301,7 @@ ifdef EXTRA_DEFINES
DEFINES += $(EXTRA_DEFINES)
DEFINES += $(EXTRA_DEFINES)
endif
endif
CFLAGS += -std=c99 -Wsign-conversion -Wconversion
-Wshadow
CFLAGS += -std=c99 -Wsign-conversion -Wconversion
$(W_SHADOW)
ifeq ($(HAS_CXX11),true)
ifeq ($(HAS_CXX11),true)
CXXFLAGS += -std=c++11
CXXFLAGS += -std=c++11
else
else
...
...
This diff is collapsed.
Click to expand it.
templates/Makefile.template
+
7
−
1
View file @
804b8553
...
@@ -187,6 +187,12 @@
...
@@ -187,6 +187,12 @@
CXX11_CHECK_CMD
=
$(
CXX
)
-std
=
c++11
-o
$(
TMPOUT
)
-c
test
/build/c++11.cc
CXX11_CHECK_CMD
=
$(
CXX
)
-std
=
c++11
-o
$(
TMPOUT
)
-c
test
/build/c++11.cc
HAS_CXX11
=
$(
shell
$(
CXX11_CHECK_CMD
)
2> /dev/null
&&
echo true
||
echo false
)
HAS_CXX11
=
$(
shell
$(
CXX11_CHECK_CMD
)
2> /dev/null
&&
echo true
||
echo false
)
CHECK_SHADOW_WORKS_CMD
=
$(
CC
)
-std
=
c99
-Werror
-Wshadow
-o
$(
TMPOUT
)
-c
test
/build/shadow.c
HAS_WORKING_SHADOW
=
$(
shell
$(
CHECK_SHADOW_WORKS_CMD
)
2> /dev/null
&&
echo true
||
echo false
)
ifeq
($(HAS_WORKING_SHADOW),true)
W_SHADOW
=
-Wshadow
endif
CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD
=
$(
CC
)
-std
=
c99
-Werror
-Wno-shift-negative-value
-o
$(
TMPOUT
)
-c
test
/build/empty.c
CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD
=
$(
CC
)
-std
=
c99
-Werror
-Wno-shift-negative-value
-o
$(
TMPOUT
)
-c
test
/build/empty.c
HAS_NO_SHIFT_NEGATIVE_VALUE
=
$(
shell
$(
CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD
)
2> /dev/null
&&
echo true
||
echo false
)
HAS_NO_SHIFT_NEGATIVE_VALUE
=
$(
shell
$(
CHECK_NO_SHIFT_NEGATIVE_VALUE_CMD
)
2> /dev/null
&&
echo true
||
echo false
)
ifeq
($(HAS_NO_SHIFT_NEGATIVE_VALUE),true)
ifeq
($(HAS_NO_SHIFT_NEGATIVE_VALUE),true)
...
@@ -207,7 +213,7 @@
...
@@ -207,7 +213,7 @@
DEFINES
+=
$(
EXTRA_DEFINES
)
DEFINES
+=
$(
EXTRA_DEFINES
)
endif
endif
CFLAGS
+=
-std
=
c99
-Wsign-conversion
-Wconversion
-Wshadow
CFLAGS
+=
-std
=
c99
-Wsign-conversion
-Wconversion
$(
W_SHADOW
)
ifeq
($(HAS_CXX11),true)
ifeq
($(HAS_CXX11),true)
CXXFLAGS
+=
-std
=
c++11
CXXFLAGS
+=
-std
=
c++11
else
else
...
...
This diff is collapsed.
Click to expand it.
test/build/boringssl.c
+
1
−
0
View file @
804b8553
...
@@ -33,6 +33,7 @@
...
@@ -33,6 +33,7 @@
// Check that boringssl is going to compile
// Check that boringssl is going to compile
#include
<stdio.h>
#include
<unistd.h>
#include
<unistd.h>
// boringssl uses anonymous unions
// boringssl uses anonymous unions
...
...
This diff is collapsed.
Click to expand it.
test/build/shadow.c
0 → 100644
+
43
−
0
View file @
804b8553
/*
*
* Copyright 2016, Google Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following disclaimer
* in the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Google Inc. nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
*/
// Check that boringssl is going to compile
#include
<stdio.h>
#include
<unistd.h>
int
main
(
void
)
{
const
char
*
close
=
"this should not shadow"
;
printf
(
"%s
\n
"
,
close
);
return
0
;
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment