Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
895c1113
Commit
895c1113
authored
8 years ago
by
murgatroid99
Browse files
Options
Downloads
Patches
Plain Diff
Make ruby library conform to status code spec
parent
1b7c0a2c
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/ruby/lib/grpc/generic/rpc_server.rb
+2
-2
2 additions, 2 deletions
src/ruby/lib/grpc/generic/rpc_server.rb
src/ruby/spec/generic/rpc_server_spec.rb
+3
-2
3 additions, 2 deletions
src/ruby/spec/generic/rpc_server_spec.rb
with
5 additions
and
4 deletions
src/ruby/lib/grpc/generic/rpc_server.rb
+
2
−
2
View file @
895c1113
...
@@ -403,7 +403,7 @@ module GRPC
...
@@ -403,7 +403,7 @@ module GRPC
loop_handle_server_calls
loop_handle_server_calls
end
end
# Sends
UNAVAILABLE
if there are too many unprocessed jobs
# Sends
RESOURCE_EXHAUSTED
if there are too many unprocessed jobs
def
available?
(
an_rpc
)
def
available?
(
an_rpc
)
jobs_count
,
max
=
@pool
.
jobs_waiting
,
@max_waiting_requests
jobs_count
,
max
=
@pool
.
jobs_waiting
,
@max_waiting_requests
GRPC
.
logger
.
info
(
"waiting:
#{
jobs_count
}
, max:
#{
max
}
"
)
GRPC
.
logger
.
info
(
"waiting:
#{
jobs_count
}
, max:
#{
max
}
"
)
...
@@ -411,7 +411,7 @@ module GRPC
...
@@ -411,7 +411,7 @@ module GRPC
GRPC
.
logger
.
warn
(
"NOT AVAILABLE: too many jobs_waiting:
#{
an_rpc
}
"
)
GRPC
.
logger
.
warn
(
"NOT AVAILABLE: too many jobs_waiting:
#{
an_rpc
}
"
)
noop
=
proc
{
|
x
|
x
}
noop
=
proc
{
|
x
|
x
}
c
=
ActiveCall
.
new
(
an_rpc
.
call
,
@cq
,
noop
,
noop
,
an_rpc
.
deadline
)
c
=
ActiveCall
.
new
(
an_rpc
.
call
,
@cq
,
noop
,
noop
,
an_rpc
.
deadline
)
c
.
send_status
(
StatusCodes
::
UNAVAILABLE
,
''
)
c
.
send_status
(
StatusCodes
::
RESOURCE_EXHAUSTED
,
''
)
nil
nil
end
end
...
...
This diff is collapsed.
Click to expand it.
src/ruby/spec/generic/rpc_server_spec.rb
+
3
−
2
View file @
895c1113
...
@@ -426,7 +426,7 @@ describe GRPC::RpcServer do
...
@@ -426,7 +426,7 @@ describe GRPC::RpcServer do
threads
.
each
(
&
:join
)
threads
.
each
(
&
:join
)
end
end
it
'should return
UNAVAILABLE
on too many jobs'
,
server:
true
do
it
'should return
RESOURCE_EXHAUSTED
on too many jobs'
,
server:
true
do
opts
=
{
opts
=
{
a_channel_arg:
'an_arg'
,
a_channel_arg:
'an_arg'
,
server_override:
@server
,
server_override:
@server
,
...
@@ -449,7 +449,8 @@ describe GRPC::RpcServer do
...
@@ -449,7 +449,8 @@ describe GRPC::RpcServer do
begin
begin
stub
.
an_rpc
(
req
)
stub
.
an_rpc
(
req
)
rescue
GRPC
::
BadStatus
=>
e
rescue
GRPC
::
BadStatus
=>
e
one_failed_as_unavailable
=
e
.
code
==
StatusCodes
::
UNAVAILABLE
one_failed_as_unavailable
=
e
.
code
==
StatusCodes
::
RESOURCE_EXHAUSTED
end
end
end
end
end
end
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment