-
- Downloads
Drop use of functools.wrap in logging_pool
functools.wrap is only warranted to work with functions and methods but logging_pool is warranted to work with callable behaviors, so using functools.wrap has been wrong all along. The particular incompatibility motivating this correction is that callable objects do not have a "__name__" attribute.
Showing
- src/python/grpcio/grpc/framework/foundation/logging_pool.py 3 additions, 4 deletionssrc/python/grpcio/grpc/framework/foundation/logging_pool.py
- src/python/grpcio/tests/unit/framework/foundation/_logging_pool_test.py 25 additions, 1 deletion...cio/tests/unit/framework/foundation/_logging_pool_test.py
Loading
Please register or sign in to comment