Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
98f2430d
Commit
98f2430d
authored
8 years ago
by
Jan Tattermusch
Browse files
Options
Downloads
Patches
Plain Diff
throw RpcException from writes after finishing
parent
6220033e
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/csharp/Grpc.Core/Internal/AsyncCall.cs
+13
-0
13 additions, 0 deletions
src/csharp/Grpc.Core/Internal/AsyncCall.cs
src/csharp/Grpc.Core/Internal/AsyncCallBase.cs
+1
-1
1 addition, 1 deletion
src/csharp/Grpc.Core/Internal/AsyncCallBase.cs
with
14 additions
and
1 deletion
src/csharp/Grpc.Core/Internal/AsyncCall.cs
+
13
−
0
View file @
98f2430d
...
@@ -443,6 +443,19 @@ namespace Grpc.Core.Internal
...
@@ -443,6 +443,19 @@ namespace Grpc.Core.Internal
}
}
}
}
protected
override
void
CheckSendingAllowed
(
bool
allowFinished
)
{
base
.
CheckSendingAllowed
(
true
);
// throwing RpcException if we already received status on client
// side makes the most sense.
// Note that this throws even for StatusCode.OK.
if
(!
allowFinished
&&
finishedStatus
.
HasValue
)
{
throw
new
RpcException
(
finishedStatus
.
Value
.
Status
);
}
}
/// <summary>
/// <summary>
/// Handles receive status completion for calls with streaming response.
/// Handles receive status completion for calls with streaming response.
/// </summary>
/// </summary>
...
...
This diff is collapsed.
Click to expand it.
src/csharp/Grpc.Core/Internal/AsyncCallBase.cs
+
1
−
1
View file @
98f2430d
...
@@ -213,7 +213,7 @@ namespace Grpc.Core.Internal
...
@@ -213,7 +213,7 @@ namespace Grpc.Core.Internal
{
{
}
}
protected
void
CheckSendingAllowed
(
bool
allowFinished
)
protected
virtual
void
CheckSendingAllowed
(
bool
allowFinished
)
{
{
GrpcPreconditions
.
CheckState
(
started
);
GrpcPreconditions
.
CheckState
(
started
);
CheckNotCancelled
();
CheckNotCancelled
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment