Skip to content
Snippets Groups Projects
Commit a0414ee1 authored by Makarand Dharmapurikar's avatar Makarand Dharmapurikar
Browse files

Addressed feedback from @jcanizales

parent 9656eca5
No related branches found
No related tags found
No related merge requests found
...@@ -42,10 +42,12 @@ ...@@ -42,10 +42,12 @@
#import <RxLibrary/GRXWriteable.h> #import <RxLibrary/GRXWriteable.h>
#import <RxLibrary/GRXWriter+Immediate.h> #import <RxLibrary/GRXWriter+Immediate.h>
#import <GRPCClient/GRPCCall+ChannelArg.h> #import <GRPCClient/GRPCCall+ChannelArg.h>
static NSString * const kHostAddress = @"localhost:5050"; static NSString * const kHostAddress = @"localhost:5050";
static NSString * const kPackage = @"grpc.testing"; static NSString * const kPackage = @"grpc.testing";
static NSString * const kService = @"TestService"; static NSString * const kService = @"TestService";
static NSString * const kRemoteSSLHost = @"grpc-test.sandbox.googleapis.com"; static NSString * const kRemoteSSLHost = @"grpc-test.sandbox.googleapis.com";
static ProtoMethod *kInexistentMethod; static ProtoMethod *kInexistentMethod;
static ProtoMethod *kEmptyCallMethod; static ProtoMethod *kEmptyCallMethod;
static ProtoMethod *kUnaryCallMethod; static ProtoMethod *kUnaryCallMethod;
...@@ -127,7 +129,6 @@ static ProtoMethod *kUnaryCallMethod; ...@@ -127,7 +129,6 @@ static ProtoMethod *kUnaryCallMethod;
XCTFail(@"Received unexpected response: %@", value); XCTFail(@"Received unexpected response: %@", value);
} completionHandler:^(NSError *errorOrNil) { } completionHandler:^(NSError *errorOrNil) {
XCTAssertNotNil(errorOrNil, @"Finished without error!"); XCTAssertNotNil(errorOrNil, @"Finished without error!");
//
XCTAssertEqual(errorOrNil.code, 12, @"Finished with unexpected error: %@", errorOrNil); XCTAssertEqual(errorOrNil.code, 12, @"Finished with unexpected error: %@", errorOrNil);
[expectation fulfill]; [expectation fulfill];
}]; }];
...@@ -257,6 +258,7 @@ static ProtoMethod *kUnaryCallMethod; ...@@ -257,6 +258,7 @@ static ProtoMethod *kUnaryCallMethod;
[self waitForExpectationsWithTimeout:8 handler:nil]; [self waitForExpectationsWithTimeout:8 handler:nil];
} }
// todo(makaradd): Move to a different file that contains only unit tests
- (void)testExceptions { - (void)testExceptions {
// Try to set userAgentPrefix for host that is nil. This should cause // Try to set userAgentPrefix for host that is nil. This should cause
// an exception. // an exception.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment