Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
a16919e1
Commit
a16919e1
authored
7 years ago
by
Eric Gribkoff
Browse files
Options
Downloads
Patches
Plain Diff
Update compression test for languages without compression bit
parent
ee145be9
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
doc/interop-test-descriptions.md
+19
-14
19 additions, 14 deletions
doc/interop-test-descriptions.md
with
19 additions
and
14 deletions
doc/interop-test-descriptions.md
+
19
−
14
View file @
a16919e1
...
@@ -183,7 +183,8 @@ the `response_compressed` boolean.
...
@@ -183,7 +183,8 @@ the `response_compressed` boolean.
Whether compression was actually performed is determined by the compression bit
Whether compression was actually performed is determined by the compression bit
in the response's message flags.
*
Note that some languages may not have access
in the response's message flags.
*
Note that some languages may not have access
to the message flags
*
.
to the message flags, in which case the client will be unable to verify that
the
`response_compressed`
boolean is obeyed by the server
*
.
Server features:
Server features:
...
@@ -218,10 +219,10 @@ Procedure:
...
@@ -218,10 +219,10 @@ Procedure:
```
```
Client asserts:
Client asserts:
* call was successful
* call was successful
* when `response_compressed` is true,
the response MUST have the
*
if supported by the implementation,
when `response_compressed` is true,
compressed message flag set.
the response MUST have the
compressed message flag set.
* when `response_compressed` is false,
the response MUST NOT have
*
if supported by the implementation,
when `response_compressed` is false,
the compressed message flag set.
the
response MUST NOT have the
compressed message flag set.
* response payload body is 314159 bytes in size in both cases.
* response payload body is 314159 bytes in size in both cases.
* clients are free to assert that the response payload body contents are
* clients are free to assert that the response payload body contents are
zero and comparing the entire response message against a golden response
zero and comparing the entire response message against a golden response
...
@@ -304,8 +305,8 @@ Procedure:
...
@@ -304,8 +305,8 @@ Procedure:
}
}
}
}
```
```
If the call fail
s
with `INVALID_ARGUMENT`, the test fails.
Otherwise, we
If the call
does not
fail with `INVALID_ARGUMENT`, the test fails.
continue.
Otherwise, we
continue.
1.
Client calls
`StreamingInputCall`
again, sending the
*compressed*
message
1.
Client calls
`StreamingInputCall`
again, sending the
*compressed*
message
...
@@ -377,7 +378,13 @@ Client asserts:
...
@@ -377,7 +378,13 @@ Client asserts:
### server_compressed_streaming
### server_compressed_streaming
This test verifies that the server can compress streaming messages and disable
This test verifies that the server can compress streaming messages and disable
compression on individual messages.
compression on individual messages, expecting the server's response to be
compressed or not according to the
`response_compressed`
boolean.
Whether compression was actually performed is determined by the compression bit
in the response's message flags.
*
Note that some languages may not have access
to the message flags, in which case the client will be unable to verify that the
`response_compressed`
boolean is obeyed by the server
*
.
Server features:
Server features:
*
[
StreamingOutputCall
][]
*
[
StreamingOutputCall
][]
...
@@ -407,15 +414,14 @@ Procedure:
...
@@ -407,15 +414,14 @@ Procedure:
Client asserts:
Client asserts:
* call was successful
* call was successful
* exactly two responses
* exactly two responses
* when `response_compressed` is false,
the response's messages MUST
*
if supported by the implementation,
when `response_compressed` is false,
NOT have the compressed message flag set.
the response's messages MUST
NOT have the compressed message flag set.
* when `response_compressed` is true,
the response's messages MUST
*
if supported by the implementation,
when `response_compressed` is true,
have the compressed message flag set.
the response's messages MUST
have the compressed message flag set.
* response payload bodies are sized (in order): 31415, 92653
* response payload bodies are sized (in order): 31415, 92653
* clients are free to assert that the response payload body contents are
* clients are free to assert that the response payload body contents are
zero and comparing the entire response messages against golden responses
zero and comparing the entire response messages against golden responses
### ping_pong
### ping_pong
This test verifies that full duplex bidi is supported.
This test verifies that full duplex bidi is supported.
...
@@ -1095,4 +1101,3 @@ Discussion:
...
@@ -1095,4 +1101,3 @@ Discussion:
Ideally, this would be communicated via metadata and not in the
Ideally, this would be communicated via metadata and not in the
request/response, but we want to use this test in code paths that don't yet
request/response, but we want to use this test in code paths that don't yet
fully communicate metadata.
fully communicate metadata.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment