Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
d322d4b3
Commit
d322d4b3
authored
8 years ago
by
Makarand Dharmapurikar
Browse files
Options
Downloads
Patches
Plain Diff
surface cacheable flag to the call
parent
4e520597
No related branches found
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
src/core/lib/channel/http_server_filter.c
+8
-1
8 additions, 1 deletion
src/core/lib/channel/http_server_filter.c
src/core/lib/surface/server.c
+8
-3
8 additions, 3 deletions
src/core/lib/surface/server.c
src/core/lib/transport/transport.h
+1
-0
1 addition, 0 deletions
src/core/lib/transport/transport.h
with
17 additions
and
4 deletions
src/core/lib/channel/http_server_filter.c
+
8
−
1
View file @
d322d4b3
...
@@ -55,6 +55,7 @@ typedef struct call_data {
...
@@ -55,6 +55,7 @@ typedef struct call_data {
grpc_metadata_batch
*
recv_initial_metadata
;
grpc_metadata_batch
*
recv_initial_metadata
;
bool
*
recv_idempotent_request
;
bool
*
recv_idempotent_request
;
bool
*
recv_cacheable_request
;
/** Closure to call when finished with the hs_on_recv hook */
/** Closure to call when finished with the hs_on_recv hook */
grpc_closure
*
on_done_recv
;
grpc_closure
*
on_done_recv
;
/** Closure to call when we retrieve read message from the payload-bin header
/** Closure to call when we retrieve read message from the payload-bin header
...
@@ -94,9 +95,13 @@ static grpc_mdelem *server_filter(void *user_data, grpc_mdelem *md) {
...
@@ -94,9 +95,13 @@ static grpc_mdelem *server_filter(void *user_data, grpc_mdelem *md) {
if
(
md
==
GRPC_MDELEM_METHOD_POST
)
{
if
(
md
==
GRPC_MDELEM_METHOD_POST
)
{
calld
->
seen_method
=
1
;
calld
->
seen_method
=
1
;
*
calld
->
recv_idempotent_request
=
false
;
*
calld
->
recv_idempotent_request
=
false
;
}
else
if
(
md
==
GRPC_MDELEM_METHOD_PUT
||
md
==
GRPC_MDELEM_METHOD_GET
)
{
*
calld
->
recv_cacheable_request
=
false
;
}
else
if
(
md
==
GRPC_MDELEM_METHOD_PUT
)
{
calld
->
seen_method
=
1
;
calld
->
seen_method
=
1
;
*
calld
->
recv_idempotent_request
=
true
;
*
calld
->
recv_idempotent_request
=
true
;
}
else
if
(
md
==
GRPC_MDELEM_METHOD_GET
)
{
calld
->
seen_method
=
1
;
*
calld
->
recv_cacheable_request
=
true
;
}
else
if
(
md
->
key
==
GRPC_MDSTR_SCHEME
)
{
}
else
if
(
md
->
key
==
GRPC_MDSTR_SCHEME
)
{
calld
->
seen_scheme
=
1
;
calld
->
seen_scheme
=
1
;
}
else
if
(
md
==
GRPC_MDELEM_TE_TRAILERS
)
{
}
else
if
(
md
==
GRPC_MDELEM_TE_TRAILERS
)
{
...
@@ -254,8 +259,10 @@ static void hs_mutate_op(grpc_call_element *elem,
...
@@ -254,8 +259,10 @@ static void hs_mutate_op(grpc_call_element *elem,
if
(
op
->
recv_initial_metadata
)
{
if
(
op
->
recv_initial_metadata
)
{
/* substitute our callback for the higher callback */
/* substitute our callback for the higher callback */
GPR_ASSERT
(
op
->
recv_idempotent_request
!=
NULL
);
GPR_ASSERT
(
op
->
recv_idempotent_request
!=
NULL
);
GPR_ASSERT
(
op
->
recv_cacheable_request
!=
NULL
);
calld
->
recv_initial_metadata
=
op
->
recv_initial_metadata
;
calld
->
recv_initial_metadata
=
op
->
recv_initial_metadata
;
calld
->
recv_idempotent_request
=
op
->
recv_idempotent_request
;
calld
->
recv_idempotent_request
=
op
->
recv_idempotent_request
;
calld
->
recv_cacheable_request
=
op
->
recv_cacheable_request
;
calld
->
on_done_recv
=
op
->
recv_initial_metadata_ready
;
calld
->
on_done_recv
=
op
->
recv_initial_metadata_ready
;
op
->
recv_initial_metadata_ready
=
&
calld
->
hs_on_recv
;
op
->
recv_initial_metadata_ready
=
&
calld
->
hs_on_recv
;
}
}
...
...
This diff is collapsed.
Click to expand it.
src/core/lib/surface/server.c
+
8
−
3
View file @
d322d4b3
...
@@ -149,6 +149,7 @@ struct call_data {
...
@@ -149,6 +149,7 @@ struct call_data {
grpc_metadata_batch
*
recv_initial_metadata
;
grpc_metadata_batch
*
recv_initial_metadata
;
bool
recv_idempotent_request
;
bool
recv_idempotent_request
;
bool
recv_cacheable_request
;
grpc_metadata_array
initial_metadata
;
grpc_metadata_array
initial_metadata
;
request_matcher
*
request_matcher
;
request_matcher
*
request_matcher
;
...
@@ -497,9 +498,12 @@ static void publish_call(grpc_exec_ctx *exec_ctx, grpc_server *server,
...
@@ -497,9 +498,12 @@ static void publish_call(grpc_exec_ctx *exec_ctx, grpc_server *server,
&
rc
->
data
.
batch
.
details
->
method_capacity
,
calld
->
path
);
&
rc
->
data
.
batch
.
details
->
method_capacity
,
calld
->
path
);
rc
->
data
.
batch
.
details
->
deadline
=
calld
->
deadline
;
rc
->
data
.
batch
.
details
->
deadline
=
calld
->
deadline
;
rc
->
data
.
batch
.
details
->
flags
=
rc
->
data
.
batch
.
details
->
flags
=
0
|
(
calld
->
recv_idempotent_request
(
calld
->
recv_idempotent_request
?
GRPC_INITIAL_METADATA_IDEMPOTENT_REQUEST
?
GRPC_INITIAL_METADATA_IDEMPOTENT_REQUEST
:
0
);
:
0
)
|
(
calld
->
recv_cacheable_request
?
GRPC_INITIAL_METADATA_CACHEABLE_REQUEST
:
0
);
break
;
break
;
case
REGISTERED_CALL
:
case
REGISTERED_CALL
:
*
rc
->
data
.
registered
.
deadline
=
calld
->
deadline
;
*
rc
->
data
.
registered
.
deadline
=
calld
->
deadline
;
...
@@ -779,6 +783,7 @@ static void server_mutate_op(grpc_call_element *elem,
...
@@ -779,6 +783,7 @@ static void server_mutate_op(grpc_call_element *elem,
calld
->
on_done_recv_initial_metadata
=
op
->
recv_initial_metadata_ready
;
calld
->
on_done_recv_initial_metadata
=
op
->
recv_initial_metadata_ready
;
op
->
recv_initial_metadata_ready
=
&
calld
->
server_on_recv_initial_metadata
;
op
->
recv_initial_metadata_ready
=
&
calld
->
server_on_recv_initial_metadata
;
op
->
recv_idempotent_request
=
&
calld
->
recv_idempotent_request
;
op
->
recv_idempotent_request
=
&
calld
->
recv_idempotent_request
;
op
->
recv_cacheable_request
=
&
calld
->
recv_cacheable_request
;
}
}
}
}
...
...
This diff is collapsed.
Click to expand it.
src/core/lib/transport/transport.h
+
1
−
0
View file @
d322d4b3
...
@@ -124,6 +124,7 @@ typedef struct grpc_transport_stream_op {
...
@@ -124,6 +124,7 @@ typedef struct grpc_transport_stream_op {
/** Receive initial metadata from the stream, into provided metadata batch. */
/** Receive initial metadata from the stream, into provided metadata batch. */
grpc_metadata_batch
*
recv_initial_metadata
;
grpc_metadata_batch
*
recv_initial_metadata
;
bool
*
recv_idempotent_request
;
bool
*
recv_idempotent_request
;
bool
*
recv_cacheable_request
;
/** Should be enqueued when initial metadata is ready to be processed. */
/** Should be enqueued when initial metadata is ready to be processed. */
grpc_closure
*
recv_initial_metadata_ready
;
grpc_closure
*
recv_initial_metadata_ready
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment