Skip to content
Snippets Groups Projects
Commit fa0fa181 authored by murgatroid99's avatar murgatroid99
Browse files

Check more warnings in Ruby library, add -Werror

parent 0b90c1e5
No related branches found
No related tags found
No related merge requests found
...@@ -54,12 +54,6 @@ LIB_DIRS = [ ...@@ -54,12 +54,6 @@ LIB_DIRS = [
LIBDIR LIBDIR
] ]
$CFLAGS << ' -Wno-implicit-function-declaration '
$CFLAGS << ' -Wno-pointer-sign '
$CFLAGS << ' -Wno-return-type '
$CFLAGS << ' -Wall '
$CFLAGS << ' -pedantic '
grpc_pkg_config = system('pkg-config --exists grpc') grpc_pkg_config = system('pkg-config --exists grpc')
if grpc_pkg_config if grpc_pkg_config
...@@ -100,5 +94,10 @@ else ...@@ -100,5 +94,10 @@ else
end end
end end
$CFLAGS << ' -std=c99 '
$CFLAGS << ' -Wall '
$CFLAGS << ' -Wextra '
$CFLAGS << ' -pedantic '
$CFLAGS << ' -Werror '
create_makefile('grpc/grpc') create_makefile('grpc/grpc')
...@@ -68,8 +68,12 @@ static void grpc_rb_server_free(void *p) { ...@@ -68,8 +68,12 @@ static void grpc_rb_server_free(void *p) {
/* Deletes the wrapped object if the mark object is Qnil, which indicates /* Deletes the wrapped object if the mark object is Qnil, which indicates
that no other object is the actual owner. */ that no other object is the actual owner. */
/* grpc_server_shutdown does not exist. Change this to something that does
or delete it */
if (svr->wrapped != NULL && svr->mark == Qnil) { if (svr->wrapped != NULL && svr->mark == Qnil) {
grpc_server_shutdown(svr->wrapped); // grpc_server_shutdown(svr->wrapped);
// Aborting to indicate a bug
abort();
grpc_server_destroy(svr->wrapped); grpc_server_destroy(svr->wrapped);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment