Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
Grpc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tci-gateway-module
Grpc
Commits
fa0fa181
Commit
fa0fa181
authored
9 years ago
by
murgatroid99
Browse files
Options
Downloads
Patches
Plain Diff
Check more warnings in Ruby library, add -Werror
parent
0b90c1e5
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/ruby/ext/grpc/extconf.rb
+5
-6
5 additions, 6 deletions
src/ruby/ext/grpc/extconf.rb
src/ruby/ext/grpc/rb_server.c
+5
-1
5 additions, 1 deletion
src/ruby/ext/grpc/rb_server.c
with
10 additions
and
7 deletions
src/ruby/ext/grpc/extconf.rb
+
5
−
6
View file @
fa0fa181
...
@@ -54,12 +54,6 @@ LIB_DIRS = [
...
@@ -54,12 +54,6 @@ LIB_DIRS = [
LIBDIR
LIBDIR
]
]
$CFLAGS
<<
' -Wno-implicit-function-declaration '
$CFLAGS
<<
' -Wno-pointer-sign '
$CFLAGS
<<
' -Wno-return-type '
$CFLAGS
<<
' -Wall '
$CFLAGS
<<
' -pedantic '
grpc_pkg_config
=
system
(
'pkg-config --exists grpc'
)
grpc_pkg_config
=
system
(
'pkg-config --exists grpc'
)
if
grpc_pkg_config
if
grpc_pkg_config
...
@@ -100,5 +94,10 @@ else
...
@@ -100,5 +94,10 @@ else
end
end
end
end
$CFLAGS
<<
' -std=c99 '
$CFLAGS
<<
' -Wall '
$CFLAGS
<<
' -Wextra '
$CFLAGS
<<
' -pedantic '
$CFLAGS
<<
' -Werror '
create_makefile
(
'grpc/grpc'
)
create_makefile
(
'grpc/grpc'
)
This diff is collapsed.
Click to expand it.
src/ruby/ext/grpc/rb_server.c
+
5
−
1
View file @
fa0fa181
...
@@ -68,8 +68,12 @@ static void grpc_rb_server_free(void *p) {
...
@@ -68,8 +68,12 @@ static void grpc_rb_server_free(void *p) {
/* Deletes the wrapped object if the mark object is Qnil, which indicates
/* Deletes the wrapped object if the mark object is Qnil, which indicates
that no other object is the actual owner. */
that no other object is the actual owner. */
/* grpc_server_shutdown does not exist. Change this to something that does
or delete it */
if
(
svr
->
wrapped
!=
NULL
&&
svr
->
mark
==
Qnil
)
{
if
(
svr
->
wrapped
!=
NULL
&&
svr
->
mark
==
Qnil
)
{
grpc_server_shutdown
(
svr
->
wrapped
);
// grpc_server_shutdown(svr->wrapped);
// Aborting to indicate a bug
abort
();
grpc_server_destroy
(
svr
->
wrapped
);
grpc_server_destroy
(
svr
->
wrapped
);
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment