Skip to content
Snippets Groups Projects
Commit 73a540ae authored by Tim Emiola's avatar Tim Emiola
Browse files

Update sites using ServerCredentials.new

parent 14d0a3c7
No related branches found
No related tags found
No related merge requests found
...@@ -155,7 +155,8 @@ end ...@@ -155,7 +155,8 @@ end
def test_server_creds def test_server_creds
certs = load_test_certs certs = load_test_certs
GRPC::Core::ServerCredentials.new(nil, certs[1], certs[2]) GRPC::Core::ServerCredentials.new(
nil, [{ private_key: certs[1], cert_chain: certs[2] }], false)
end end
def main def main
......
...@@ -77,7 +77,8 @@ end ...@@ -77,7 +77,8 @@ end
def test_server_creds def test_server_creds
certs = load_test_certs certs = load_test_certs
GRPC::Core::ServerCredentials.new(nil, certs[1], certs[2]) GRPC::Core::ServerCredentials.new(
nil, [{ private_key: certs[1], cert_chain: certs[2] }], false)
end end
def main def main
......
...@@ -64,7 +64,8 @@ end ...@@ -64,7 +64,8 @@ end
# creates a ServerCredentials from the test certificates. # creates a ServerCredentials from the test certificates.
def test_server_creds def test_server_creds
certs = load_test_certs certs = load_test_certs
GRPC::Core::ServerCredentials.new(nil, certs[1], certs[2]) GRPC::Core::ServerCredentials.new(
nil, [{private_key: certs[1], cert_chain: certs[2]}], false)
end end
# produces a string of null chars (\0) of length l. # produces a string of null chars (\0) of length l.
......
...@@ -32,12 +32,6 @@ require 'spec_helper' ...@@ -32,12 +32,6 @@ require 'spec_helper'
include GRPC::Core include GRPC::Core
def load_test_certs
test_root = File.join(File.dirname(__FILE__), 'testdata')
files = ['ca.pem', 'server1.key', 'server1.pem']
files.map { |f| File.open(File.join(test_root, f)).read }
end
shared_context 'setup: tags' do shared_context 'setup: tags' do
let(:sent_message) { 'sent message' } let(:sent_message) { 'sent message' }
let(:reply_text) { 'the reply' } let(:reply_text) { 'the reply' }
...@@ -420,12 +414,19 @@ describe 'the http client/server' do ...@@ -420,12 +414,19 @@ describe 'the http client/server' do
end end
describe 'the secure http client/server' do describe 'the secure http client/server' do
def load_test_certs
test_root = File.join(File.dirname(__FILE__), 'testdata')
files = ['ca.pem', 'server1.key', 'server1.pem']
files.map { |f| File.open(File.join(test_root, f)).read }
end
before(:example) do before(:example) do
certs = load_test_certs certs = load_test_certs
server_host = '0.0.0.0:0' server_host = '0.0.0.0:0'
@client_queue = GRPC::Core::CompletionQueue.new @client_queue = GRPC::Core::CompletionQueue.new
@server_queue = GRPC::Core::CompletionQueue.new @server_queue = GRPC::Core::CompletionQueue.new
server_creds = GRPC::Core::ServerCredentials.new(nil, certs[1], certs[2]) server_creds = GRPC::Core::ServerCredentials.new(
nil, [{ private_key: certs[1], cert_chain: certs[2] }], false)
@server = GRPC::Core::Server.new(@server_queue, nil) @server = GRPC::Core::Server.new(@server_queue, nil)
server_port = @server.add_http2_port(server_host, server_creds) server_port = @server.add_http2_port(server_host, server_creds)
@server.start @server.start
......
...@@ -29,15 +29,15 @@ ...@@ -29,15 +29,15 @@
require 'grpc' require 'grpc'
def load_test_certs describe GRPC::Core::Credentials do
test_root = File.join(File.dirname(__FILE__), 'testdata') Credentials = GRPC::Core::Credentials
files = ['ca.pem', 'server1.pem', 'server1.key']
files.map { |f| File.open(File.join(test_root, f)).read }
end
Credentials = GRPC::Core::Credentials def load_test_certs
test_root = File.join(File.dirname(__FILE__), 'testdata')
files = ['ca.pem', 'server1.pem', 'server1.key']
files.map { |f| File.open(File.join(test_root, f)).read }
end
describe Credentials do
describe '#new' do describe '#new' do
it 'can be constructed with fake inputs' do it 'can be constructed with fake inputs' do
expect { Credentials.new('root_certs', 'key', 'cert') }.not_to raise_error expect { Credentials.new('root_certs', 'key', 'cert') }.not_to raise_error
......
...@@ -31,8 +31,9 @@ require 'grpc' ...@@ -31,8 +31,9 @@ require 'grpc'
def load_test_certs def load_test_certs
test_root = File.join(File.dirname(__FILE__), 'testdata') test_root = File.join(File.dirname(__FILE__), 'testdata')
files = ['ca.pem', 'server1.pem', 'server1.key'] files = ['ca.pem', 'server1.key', 'server1.pem']
files.map { |f| File.open(File.join(test_root, f)).read } contents = files.map { |f| File.open(File.join(test_root, f)).read }
[contents[0], [{ private_key: contents[1], cert_chain: contents[2] }], false]
end end
describe GRPC::Core::ServerCredentials do describe GRPC::Core::ServerCredentials do
...@@ -40,7 +41,8 @@ describe GRPC::Core::ServerCredentials do ...@@ -40,7 +41,8 @@ describe GRPC::Core::ServerCredentials do
describe '#new' do describe '#new' do
it 'can be constructed from a fake CA PEM, server PEM and a server key' do it 'can be constructed from a fake CA PEM, server PEM and a server key' do
expect { Creds.new('a', 'b', 'c') }.not_to raise_error creds = Creds.new('a', [{ private_key: 'a', cert_chain: 'b' }], false)
expect(creds).to_not be_nil
end end
it 'can be constructed using the test certificates' do it 'can be constructed using the test certificates' do
...@@ -48,21 +50,44 @@ describe GRPC::Core::ServerCredentials do ...@@ -48,21 +50,44 @@ describe GRPC::Core::ServerCredentials do
expect { Creds.new(*certs) }.not_to raise_error expect { Creds.new(*certs) }.not_to raise_error
end end
it 'cannot be constructed without a nil key_cert pair array' do
root_cert, _, _ = load_test_certs
blk = proc do
Creds.new(root_cert, nil, false)
end
expect(&blk).to raise_error
end
it 'cannot be constructed without any key_cert pairs' do
root_cert, _, _ = load_test_certs
blk = proc do
Creds.new(root_cert, [], false)
end
expect(&blk).to raise_error
end
it 'cannot be constructed without a server cert chain' do it 'cannot be constructed without a server cert chain' do
root_cert, server_key, _ = load_test_certs root_cert, server_key, _ = load_test_certs
blk = proc { Creds.new(root_cert, server_key, nil) } blk = proc do
Creds.new(root_cert,
[{ server_key: server_key, cert_chain: nil }],
false)
end
expect(&blk).to raise_error expect(&blk).to raise_error
end end
it 'cannot be constructed without a server key' do it 'cannot be constructed without a server key' do
root_cert, _, _ = load_test_certs root_cert, _, _ = load_test_certs
blk = proc { Creds.new(root_cert, nil, cert_chain) } blk = proc do
Creds.new(root_cert,
[{ server_key: nil, cert_chain: cert_chain }])
end
expect(&blk).to raise_error expect(&blk).to raise_error
end end
it 'can be constructed without a root_cret' do it 'can be constructed without a root_cret' do
_, server_key, cert_chain = load_test_certs _, cert_pairs, _ = load_test_certs
blk = proc { Creds.new(nil, server_key, cert_chain) } blk = proc { Creds.new(nil, cert_pairs, false) }
expect(&blk).to_not raise_error expect(&blk).to_not raise_error
end end
end end
......
...@@ -32,7 +32,8 @@ require 'grpc' ...@@ -32,7 +32,8 @@ require 'grpc'
def load_test_certs def load_test_certs
test_root = File.join(File.dirname(__FILE__), 'testdata') test_root = File.join(File.dirname(__FILE__), 'testdata')
files = ['ca.pem', 'server1.key', 'server1.pem'] files = ['ca.pem', 'server1.key', 'server1.pem']
files.map { |f| File.open(File.join(test_root, f)).read } contents = files.map { |f| File.open(File.join(test_root, f)).read }
[contents[0], [{ private_key: contents[1], cert_chain: contents[2] }], false]
end end
Server = GRPC::Core::Server Server = GRPC::Core::Server
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment