Skip to content
Snippets Groups Projects
Commit b423f579 authored by ncteisen's avatar ncteisen
Browse files

Disambiguate trickle and normal bms

parent 6dc4c7f5
No related branches found
No related tags found
No related merge requests found
...@@ -20,4 +20,4 @@ set -ex ...@@ -20,4 +20,4 @@ set -ex
cd $(dirname $0)/../.. cd $(dirname $0)/../..
tools/run_tests/start_port_server.py tools/run_tests/start_port_server.py
tools/profiling/microbenchmarks/bm_diff/bm_main.py -d origin/$ghprbTargetBranch -b bm_fullstack_trickle -l 4 -t cli_transport_stalls cli_stream_stalls svr_transport_stalls svr_stream_stalls --no-counters tools/profiling/microbenchmarks/bm_diff/bm_main.py -d origin/$ghprbTargetBranch -b bm_fullstack_trickle -l 4 -t cli_transport_stalls cli_stream_stalls svr_transport_stalls svr_stream_stalls --no-counters --pr_comment_name trickle
...@@ -80,6 +80,11 @@ def _args(): ...@@ -80,6 +80,11 @@ def _args():
type=int, type=int,
default=multiprocessing.cpu_count(), default=multiprocessing.cpu_count(),
help='Number of CPUs to use') help='Number of CPUs to use')
argp.add_argument(
'--pr_comment_name',
type=str,
default="microbenchmarks",
help='Name that Jenkins will use to commen on the PR')
argp.add_argument('--counters', dest='counters', action='store_true') argp.add_argument('--counters', dest='counters', action='store_true')
argp.add_argument('--no-counters', dest='counters', action='store_false') argp.add_argument('--no-counters', dest='counters', action='store_false')
argp.set_defaults(counters=True) argp.set_defaults(counters=True)
...@@ -126,9 +131,9 @@ def main(args): ...@@ -126,9 +131,9 @@ def main(args):
diff, note = bm_diff.diff(args.benchmarks, args.loops, args.track, old, diff, note = bm_diff.diff(args.benchmarks, args.loops, args.track, old,
'new', args.counters) 'new', args.counters)
if diff: if diff:
text = 'Performance differences noted:\n' + diff text = '[%s] Performance differences noted:\n%s' % (args.pr_comment_name, diff)
else: else:
text = 'No significant performance differences' text = '[%s] No significant performance differences' % args.pr_comment_name
if note: if note:
text = note + '\n\n' + text text = note + '\n\n' + text
print('%s' % text) print('%s' % text)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment