Skip to content
Snippets Groups Projects
  1. Apr 27, 2015
  2. Apr 23, 2015
  3. Apr 22, 2015
  4. Apr 21, 2015
  5. Apr 07, 2015
  6. Apr 06, 2015
  7. Apr 03, 2015
  8. Mar 19, 2015
    • Nicolas Noble's avatar
      Various Windows fixes. · cfd6073a
      Nicolas Noble authored
      -) using dupenv_s instead of getenv_s and calling strdup ourselves.
      -) few impossible-to-obtain if checks.
      -) various signed/unsigned casting.
      -) using time_t instead of time32_t
      -) checking output of FormatMessage for failures.
      -) don't redefine _WIN32_WINNT without undefining it first.
      -) fixed msvc's interlocked casting.
      -) renamed AddPort to AddListeningPort.
      -) added protobuf's third_party includes to search path.
      -) added a missing definition for inet_ntop in mingw32.
      -) removed useless declarations.
      cfd6073a
  9. Mar 16, 2015
  10. Mar 12, 2015
  11. Mar 10, 2015
  12. Mar 06, 2015
  13. Mar 04, 2015
  14. Mar 03, 2015
  15. Mar 02, 2015
    • Eric Anderson's avatar
      Remove HTTP mappings from status.h · 5b53e35b
      Eric Anderson authored
      The mappings are a combination of useless, inaccurate, and harmful.
      Leave them out until they are helpful and correct.
      
      Fundamental issues:
       - If in need of mappings, a user would need HTTP -> gRPC code mappings.
         But the docs don't provide that since the mappings are not 1:1.
       - There _is no_ gRPC -> HTTP code mapping taking place in gRPC. This
         may change in the future, but until then the docs are misleading.
      
      But even given those were resolved, there are additional issues. Two
      obvious examples:
       - 501 Not Implemented is refering to HTTP methods such as GET and POST
         not being implement. That should not be used for gRPC methods not
         found (UNIMPLEMENTED).
       - 404 Not Found is for when the resource is not found. In gRPC, the
         resource is the gRPC method, not the parameters (NOT_FOUND). If there
         is a REST conversion layer on top of gRPC, then 404 would be
         appropriate, but that just shows that the mapping can not be
         canonical.
      5b53e35b
    • Misha Brukman's avatar
      5cdf37eb
  16. Feb 27, 2015
  17. Feb 25, 2015
  18. Feb 24, 2015
Loading